scala-network / scala-v7

A cryptocurrency aiming to use blockchain technologies to globally distribute wealth.
Other
83 stars 27 forks source link

Increase buffer size by 100000 for blockchain import and export #47

Closed donovansolms closed 5 years ago

donovansolms commented 5 years ago

This fixes the currently broken stellite-blockchain-import utility. When you export the current chain, you'll see the following warnings:

2019-02-22 13:44:28.634        7fe755b76740    INFO     bcutil    src/blockchain_utilities/bootstrap_file.cpp:319    Number of blocks exported: 513501
2019-02-22 13:44:28.636        7fe755b76740    INFO     bcutil    src/blockchain_utilities/bootstrap_file.cpp:321    Largest chunk: 1034953 bytes
2019-02-22 13:44:28.641        7fe755b76740    WARN     bcutil    src/blockchain_utilities/blockchain_export.cpp:195    Blockchain raw data exported OK

Largest chunk: 1034953 bytes is the issue here. Even though the buffer is set to 1000000, the exported doesn't honor it causing the import to fail with the error Exception at [Import error], what=Aborting: chunk size exceeds buffer size.

This PR raises the buffer size to 1100000 bytes (100000 bytes increase), which resolves the issue.

A reference from Monero is in this issue but that wasn't really solved. I can confirm the chain isn't corrupted as mentioned here as I did an export and import on the same server using a cleanly synced chain and import verification enabled.

hayzamjs commented 5 years ago

Looks fine 🙆‍♂️