search

scala-steward-org / scala-steward

:robot: A bot that helps you keep your projects up-to-date
Apache License 2.0
1.15k stars 502 forks source link

Could/should scala-steward scala version PRs update github actions? #1996

Closed nafg closed 3 years ago

nafg commented 3 years ago

In particular ones generated by sbt-github-actions. It should make changes like these https://github.com/nafg/slick-additions/commit/b24524448f6e06d059d6e4724c088a40b9036d2c#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f, otherwise the build will fail

fthomas commented 3 years ago

It will regenerate the workflow on the next Scala update: https://github.com/scala-steward-org/scala-steward/pull/1993

nafg commented 3 years ago

Amazing!

On Sun, Mar 7, 2021, 12:40 AM Frank S. Thomas notifications@github.com wrote:

Closed #1996 https://github.com/scala-steward-org/scala-steward/issues/1996.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/scala-steward-org/scala-steward/issues/1996#event-4417679561, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYAUF3KDL76JU6Q2E645LTCMGUVANCNFSM4YXPXGJA .

nafg commented 3 years ago

I guess the more you have the more you want...

What about .mergify.yml -- that has to be kept in sync with the scala version too...

I suppose if you're updating the actions via the sbt task,I could override the task to do it and then get it for free

On Sun, Mar 7, 2021, 10:06 AM Naftoli Gugenheim naftoligug@gmail.com wrote:

Amazing!

On Sun, Mar 7, 2021, 12:40 AM Frank S. Thomas notifications@github.com wrote:

Closed #1996 https://github.com/scala-steward-org/scala-steward/issues/1996.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/scala-steward-org/scala-steward/issues/1996#event-4417679561, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYAUF3KDL76JU6Q2E645LTCMGUVANCNFSM4YXPXGJA .

nafg commented 3 years ago

Also the build failing is not as bad as mergify thinking it's not ready to be merged... I could merge it manually. After all I have to mark it Ready for Review anyway. And I can update the file after I merge it.

(Part of the issue is that since scala-steward prs are in a fork, I can't push to the pr branch)

On Sun, Mar 7, 2021, 10:19 AM Naftoli Gugenheim naftoligug@gmail.com wrote:

I guess the more you have the more you want...

What about .mergify.yml -- that has to be kept in sync with the scala version too...

I suppose if you're updating the actions via the sbt task,I could override the task to do it and then get it for free

On Sun, Mar 7, 2021, 10:06 AM Naftoli Gugenheim naftoligug@gmail.com wrote:

Amazing!

On Sun, Mar 7, 2021, 12:40 AM Frank S. Thomas notifications@github.com wrote:

Closed #1996 https://github.com/scala-steward-org/scala-steward/issues/1996.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/scala-steward-org/scala-steward/issues/1996#event-4417679561, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYAUF3KDL76JU6Q2E645LTCMGUVANCNFSM4YXPXGJA .