search

scala-steward-org / scala-steward

:robot: A bot that helps you keep your projects up-to-date
Apache License 2.0
1.15k stars 502 forks source link

Cron expression does not work as intended #2184

Open florianmutter opened 3 years ago

florianmutter commented 3 years ago

We have set pullRequests.frequency = "0 0 1 * ?" in our .scala-steward.conf. Our expectation is that scala steward only creates new pull requests on the 1. of each month. Scala steward runs every day in the evening.

Despite the config it created a new pull request a few days ago. Here is the log:

  2021-07-13 20:05:29,074 INFO  ──────────── Steward fid-dev/guinevere ────────────
  2021-07-13 20:05:29,076 INFO  Check cache of fid-dev/guinevere
  2021-07-13 20:05:29,512 INFO  Clone fid-dev/guinevere
  2021-07-13 20:05:30,945 INFO  Refresh cache of fid-dev/guinevere
  2021-07-13 20:05:31,057 INFO  Parsed RepoConfig(CommitsConfig(None),PullRequestsConfig(Some(CronExpr(0 0 0 1 * ?))),ScalafmtConfig(None),UpdatesConfig(List(),List(),List(),None,None,None),None,None)
  2021-07-13 20:06:21,270 INFO  Parsed RepoConfig(CommitsConfig(None),PullRequestsConfig(Some(CronExpr(0 0 0 1 * ?))),ScalafmtConfig(None),UpdatesConfig(List(),List(),List(),None,None,None),None,None)
  2021-07-13 20:06:21,291 INFO  Find updates for fid-dev/guinevere
  2021-07-13 20:06:35,583 INFO  Ignore com.typesafe.akka:(akka-http, akka-http_2.12) : 10.2.4 -> 10.2.5-M1 (reason: no suitable next version)
  2021-07-13 20:06:35,584 INFO  Ignore com.typesafe.akka:(akka-http-spray-json, akka-http-spray-json_2.12) : 10.2.4 -> 10.2.5-M1 (reason: no suitable next version)
  2021-07-13 20:06:35,693 INFO  Found 17 updates:
    com.lightbend.akka:(akka-stream-alpakka-ftp, akka-stream-alpakka-ftp_2.12) : 2.0.2 -> 3.0.2
    com.lightbend.akka:(akka-stream-alpakka-sns, akka-stream-alpakka-sns_2.12) : 2.0.2 -> 3.0.2
    com.softwaremill.sttp.tapir:(tapir-akka-http-server, tapir-akka-http-server_2.12) : 0.17.19 -> 0.17.20
    com.typesafe.scala-logging:(scala-logging, scala-logging_2.12) : 3.9.3 -> 3.9.4
    org.flywaydb:flyway-core : 5.2.4 -> 7.11.2
    org.postgresql:postgresql : 42.2.18 -> 42.2.23
    org.scala-sbt:sbt : 1.4.9 -> 1.5.5
    org.scalameta:(scalafmt-core, scalafmt-core_2.13) : 2.6.4 -> 2.7.5
    software.amazon.awssdk:sns : 2.16.51 -> 2.16.100
    software.amazon.awssdk:sns : 2.16.51 -> 2.16.100
    software.amazon.awssdk:sqs : 2.16.51 -> 2.16.100
    software.amazon.awssdk:sqs : 2.16.51 -> 2.16.100
    com.github.norwae:(ignifera, ignifera_2.12) : 1.0.1 -> 1.0.2
    com.typesafe.akka:(akka-stream-testkit, akka-stream-testkit_2.12) : 2.6.14 -> 2.6.15
    com.typesafe.sbt:sbt-native-packager : 1.6.1 -> 1.6.2
    de.fashionid:fid-package-plugin : 2.0.23 -> 2.0.31
    org.scala-lang.modules:(scala-xml, scala-xml_2.12) : 1.3.0 -> 2.0.0
  2021-07-13 20:06:35,727 INFO  Ignoring outdated dependencies according to CronExpr(0 0 0 1 * ?)
  2021-07-13 20:06:35,729 INFO  fid-dev/guinevere is outdated:
    PR outdated: com.github.norwae:(ignifera, ignifera_2.12) : 1.0.1 -> 1.0.2 (https://github.com/fid-dev/guinevere/pull/276)
    PR outdated: com.typesafe.akka:(akka-stream-testkit, akka-stream-testkit_2.12) : 2.6.14 -> 2.6.15 (https://github.com/fid-dev/guinevere/pull/280)
    PR outdated: com.typesafe.sbt:sbt-native-packager : 1.6.1 -> 1.6.2 (https://github.com/fid-dev/guinevere/pull/282)
    PR outdated: org.scala-lang.modules:(scala-xml, scala-xml_2.12) : 1.3.0 -> 2.0.0 (https://github.com/fid-dev/guinevere/pull/288)
  2021-07-13 20:06:35,730 INFO  Nurture fid-dev/guinevere
  2021-07-13 20:06:35,736 INFO  Found 4 updates:
    com.github.norwae:(ignifera, ignifera_2.12) : 1.0.1 -> 1.0.2
    com.typesafe.akka:(akka-stream-testkit, akka-stream-testkit_2.12) : 2.6.14 -> 2.6.15
    com.typesafe.sbt:sbt-native-packager : 1.6.1 -> 1.6.2
    org.scala-lang.modules:(scala-xml, scala-xml_2.12) : 1.3.0 -> 2.0.0
  2021-07-13 20:06:35,743 INFO  Process update com.github.norwae:(ignifera, ignifera_2.12) : 1.0.1 -> 1.0.2
  2021-07-13 20:06:35,921 INFO  Found PR https://github.com/fid-dev/guinevere/pull/276
  2021-07-13 20:06:36,077 INFO  PR has no conflict with master
  2021-07-13 20:06:36,111 INFO  Process update com.typesafe.akka:(akka-stream-testkit, akka-stream-testkit_2.12) : 2.6.14 -> 2.6.15
  2021-07-13 20:06:36,454 INFO  Trying heuristic 'moduleId'
  2021-07-13 20:06:36,479 INFO  Trying heuristic 'strict'
  2021-07-13 20:06:36,511 INFO  Trying heuristic 'original'
  2021-07-13 20:06:36,538 INFO  Trying heuristic 'relaxed'
  2021-07-13 20:06:36,594 INFO  Create branch update/akka-stream-testkit-2.6.15
  2021-07-13 20:06:36,639 INFO  Push 1 commit(s)
  2021-07-13 20:06:39,079 INFO  Create PR update/akka-stream-testkit-2.6.15
  2021-07-13 20:06:47,774 INFO  Created PR https://github.com/fid-dev/guinevere/pull/324
  ...
fthomas commented 3 years ago 
  2021-07-13 20:06:35,729 INFO  fid-dev/guinevere is outdated:
    ...
    PR outdated: com.typesafe.akka:(akka-stream-testkit, akka-stream-testkit_2.12) : 2.6.14 -> 2.6.15 (https://github.com/fid-dev/guinevere/pull/280)

It detected an already existing PR (https://github.com/fid-dev/guinevere/pull/280) that (maybe) needed to be synchronized with the base branch. But apparently it didn't found and updated that PR and created a new one instead. What happened with https://github.com/fid-dev/guinevere/pull/280? Was it deleted?

florianmutter commented 3 years ago

It is still open but it is a PR with multiple updates all in one: grafik In both PRs it updates exactly the same variable used for all akka dependencies but in the second it only detected one dependency that needs updating... at least in the logs.

Change from initial PR: grafik

Change from newly created PR: grafik

So it seems it did not manage to connect the old PR with the new update?