search

scala-steward-org / scala-steward

:robot: A bot that helps you keep your projects up-to-date
Apache License 2.0
1.13k stars 491 forks source link

Combine `RepoConfig` with the one taken the higher importance on the right side #3346

Closed mzuehlke closed 2 months ago

mzuehlke commented 2 months ago

This is done in the RepoConfigLoader with the default config and the supplied additional configs. And now here in the same way.

The RepoConfig.combine function treats the 2nd argument as the one overwriting the 1st one in cas emerging doesn't make sense. This applies at the moment only for "pin".

This fixes the problem reported in https://github.com/typelevel/sbt-typelevel/pull/703#issuecomment-2079703210 Without the fix the https://github.com/typelevel/sbt-typelevel/blob/main/.scala-steward.conf was overwriting the config supplied by the repo https://github.com/typelevel/sbt-typelevel/blob/main/.scala-steward.conf This became a problem after #3305 and resulted in a not wanted pull request: https://github.com/typelevel/sbt-typelevel/pull/703