Closed SethTisue closed 5 years ago
https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/1923/ running on 2.13.0-pre-63769af is SUCCESS 94 UNEXPECTED 0
, so we're good to go again for RC1, knock on wood
@sjrd will do (after I unfreeze all the project SHAs after RC1 is out)
Adriaan suggested testing scala-js now rather than waiting, so I pushed https://github.com/scala/community-builds/commit/3306bd8de569b005a937777715a38de94c56d18a and to get fast feedback did a local, scala-js-only run. there were 2 test failures: https://gist.github.com/SethTisue/d83b051d0be8890346ad8612122aa245
the tests are testing error messages, and it looks plausible to me that the additional errors the compiler are now generating are probably reasonable errors coming from @adriaanm's recent rechecks changes; or if they do indicate that refchecks is now a bit overzealous in a few cases, it's probably not a release blocker? /cc @sjrd
Oh I had forgotten that the community build performed the compiler/test
. Yeah, those were broken ~2 weeks ago, and I haven't had time to investigate them. I don't consider them a blocker, but I can have a look today.
Yeah, the error messages (I assume) are related to refchecks, which now checks all pairs in the override chain.
OK, I can now confirm that the new error messages are progressions.
I updated https://github.com/scala/community-builds/blob/2.13.x/report/Report.scala a day or two ago to include all the failure reasons (to the extent they're known)
current nightly:
2.13.0-pre-59975bb2.13.0-pre-af244102.13.0-pre-b4926efI did a sweep through the latest run log at https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/ , findings as follows (numbers are "number of downstream projects blocked")
advice for those who want to help is now up at https://github.com/scala/community-builds/wiki/Troubleshooting-a-failure . I can expand and update it in response to questions. you can also help simply by eyeballing a failure and investigating it by reading code, and posting your findings here
might possibly have hit as-yet-unknown 2.13 regressions:
I also found some projects that are only failing for trivial-looking reasons. we could submit upstream fixes, or just put fixes or workarounds in our forks, and see if that uncovers any real issues (or, in some cases, unblocks downstream stuff):
PartialFunction
overload, should be easy workaroundimport
shadows local identifiers?remove
vsremoved
fix neededand then this is a dilemma:
fixed
foo bar ()
syntax thank you @Philippus and @godenjinot green, but investigated, and no unreported Scala regression seems present