search

scala / collection-strawman

Implementation of the new Scala 2.13 Collections
Apache License 2.0
200 stars 72 forks source link

Make MapWrapper.Entry's hashCode conform to the contract in java.util.Map.Entry's documentation #487

Closed isnotinvain closed 6 years ago

isnotinvain commented 6 years ago

This is a port of https://github.com/scala/scala/pull/6233 , which fixes scala/bug#10663

In the above PR, I also deleted a test (test/files/run/t5880.scala) that was testing for good spread in the (better but incorrect) hashcode implementation. I don't see that same test anywhere in this repo however.

isnotinvain commented 6 years ago

Thanks for the fast review @julienrf ! Anything left to do before merging?

isnotinvain commented 6 years ago

Thanks!