Fix soundness issues - Githubissues

odersky commented 6 years ago

This fixes or silences the soundness issues discovered by the recent tightening of checks in Dotty. The main changes were

added lots of @uncheckedVaraiance annotations to protected[this] definitions
disabled specializations of WithFilter. @szeiger maybe you can take another look, the way they are they are definitely unsound.
added some missing overrides in Stack/Queue.

This was pretty hard going, in particular figuring out the problems in the WithFilter swamp. Please, let's merge this quickly and let's not fail dotty compilation again. It would be great if this was the last time I had to rescue the dotty build.

odersky commented 6 years ago

The dotty branch that compiles this has been merged into master (PR #4162). @allanrenucci can you add a commit or do a separate PR to use the right dotty version for the build?

allanrenucci commented 6 years ago

Superseded by #521

scala / collection-strawman

Fix soundness issues #519