Stream/LazyList.addString should not force

scala / collection-strawman

Implementation of the new Scala 2.13 Collections

Apache License 2.0

200 stars 72 forks source link

Stream/LazyList.addString should not force #550

Closed lrytz closed 6 years ago

lrytz commented 6 years ago

In 2.12, stream.addString adds ? and detects cycles, similar to what toString does in the new collections.

Once this is fixed, re-enable tests commented out with TODO-newColl in test/files/run/t8680.scala.

szeiger commented 6 years ago

There's a very unfortunate asymmetry between mkString and addString due to the way https://github.com/scala/bug/issues/8680 was resolved. It would be nice to come up with a better solution but OTOH we already have more than enough breaking changes.