search

scala / community-build

Scala 2 community build — a corpus of open-source repos built against Scala nightlies
Apache License 2.0
138 stars 60 forks source link

re-enable Metals tests #1692

Closed SethTisue closed 1 year ago

SethTisue commented 1 year ago

references https://github.com/scalameta/metals/issues/5438

https://scala-ci.typesafe.com/job/scala-2.13.x-jdk11-integrate-community-build/4694/ queued

SethTisue commented 1 year ago

https://scala-ci.typesafe.com/job/scala-2.13.x-jdk11-integrate-community-build/4694/artifact/logs/metals-build.log

[metals] [error] Failed tests:
[metals] [error]    tests.pc.CompletionDocSuite
[metals] [error]    tests.pc.SignatureHelpDocSuite
SethTisue commented 1 year ago

looks like just overly sensitive tests. I can return to it after 2.13.12 is out.

SethTisue commented 1 year ago

closing for now. I've set a reminder to reopen, post-2.13.12

SethTisue commented 1 year ago

relevant PR is https://github.com/scalameta/metals/pull/5624

SethTisue commented 1 year ago

@tgodzik @kasiaMarek I see that exemptions made in https://github.com/scalameta/metals/pull/5624 were made for the Scala version "2.13.12" specifically, but we've moved on and the current Scala nightly version is now 2.13.13-bin-03faab9. No rush, but could I ask you to adjust that code appropriately, so that anything that begins with "2.13.13" uses the 2.13.12 expected outputs?

Wouldn't hurt to future-proof it for 2.13.14 and beyond, too :-)

SethTisue commented 1 year ago

oh, and there's a new CompletionSuite failure, too:

[metals] [info] tests.pc.CompletionSuite.ordering-1_2.13.13-bin-03faab9 started
[metals] [error] ==> X tests.pc.CompletionSuite.ordering-1_2.13.13-bin-03faab9  0.021s munit.ComparisonFailException: /home/jenkins/workspace/scala-2.13.x-jdk11-integrate-community-build/target-0.9.20/project-builds/metals-5a5724a2d8b7b8cfb4a47e35511bb0433bea29a1/tests/cross/src/test/scala/tests/pc/CompletionSuite.scala:1262
[metals] [error] 1261:
[metals] [error] 1262:  check(
[metals] [error] 1263:    "ordering-1",
[metals] [error] diff assertion failed
[metals] [error] => Obtained
[metals] [error]     """|dynamics scala.languageFeature
[metals] [error]        |existentials scala.languageFeature
[metals] [error]        |experimental scala.languageFeature
[metals] [error]        |implicitConversions scala.languageFeature
[metals] [error]        |postfixOps scala.languageFeature
[metals] [error]        |""".stripMargin
[metals] [error] => Diff (- obtained, + expected)
[metals] [error]  experimental scala.languageFeature
[metals] [error] +higherKinds scala.languageFeature
[metals] [error]  implicitConversions scala.languageFeature
[metals] [error] -postfixOps scala.languageFeature
[metals] [error]     at munit.Assertions.failComparison(Assertions.scala:274)
SethTisue commented 1 year ago

thank you Katarzyna!

this PR is now superseded by #1700