scala / community-build

Scala 2 community build — a corpus of open-source repos built against Scala nightlies
Apache License 2.0
139 stars 59 forks source link

move to Scalameta 4.10.x #1722

Closed SethTisue closed 1 month ago

SethTisue commented 2 months ago

~https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2119/~ ~https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2122/~ ~https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2167/~ https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2169/

SethTisue commented 2 months ago

hmm

[scalafix] [error] sbt.librarymanagement.ResolveException: Error downloading ch.epfl.scala:sbt-scalafix;sbtVersion=1.0;scalaVersion=2.12:0.12.1+21-8f7d5d40-SNAPSHOT
[scalafix] [error]   Not found
[scalafix] [error]   Not found
[scalafix] [error]   not found: /home/jenkins/.ivy2/local/ch.epfl.scala/sbt-scalafix/scala_2.12/sbt_1.0/0.12.1+21-8f7d5d40-SNAPSHOT/ivys/ivy.xml
[scalafix] [error]   not found: https://scala-ci.typesafe.com/artifactory/dbuild/ch/epfl/scala/sbt-scalafix_2.12_1.0/0.12.1+21-8f7d5d40-SNAPSHOT/sbt-scalafix-0.12.1+21-8f7d5d40-SNAPSHOT.pom
[scalafix] [error]   not found: https://scala-ci.typesafe.com/artifactory/dbuild-ivy/ch.epfl.scala/sbt-scalafix/scala_2.12/sbt_1.0/0.12.1+21-8f7d5d40-SNAPSHOT/ivys/ivy.xml
[scalafix] [error]  at lmcoursier.CoursierDependencyResolution.unresolvedWarningOrThrow(CoursierDependencyResolution.scala:346)
SethTisue commented 2 months ago

huh, they are actually depending on a snapshot, with resolvers ++= Resolver.sonatypeOssRepos("snapshots"), as of scalacenter/scalafix@90edc531378cc09e99416f11b0a398295578b053

SethTisue commented 2 months ago

FAILURES (UNEXPECTED): scalafix,ammonite

for Ammonite to be green again, https://github.com/com-lihaoyi/Ammonite/pull/1528 would have to be merged. I can make a little noise on that PR (and perhaps on Discord), but in the meantime boot Ammonite from the build, they need to keep current on this or we can't keep them in

the scalafix error (https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2122/artifact/logs/scalafix-build.log) is harder to figure

SethTisue commented 2 months ago

Scalameta 4.10.0 is out, not sure when everybody will upgrade

SethTisue commented 1 month ago

Scalafix upgraded: https://github.com/scalacenter/scalafix/pull/2078

SethTisue commented 1 month ago

🎉🎉🎉, green except for catbird and ammonite. merging. 'll deal with those two separately, probably by ejecting them from the build but letting the maintainers know what they'd need to in order to be included again

SethTisue commented 1 month ago

ongoing 👏 to @kitbellew and @bjaglin for your efforts

SethTisue commented 1 month ago

catbird, I was able to just disable a subproject; I notified the maintainer

ammonite: removed in ed884b5d17a37c2f1d14f31b8174c1cb0a61d01d, but I notified the maintainers at https://github.com/com-lihaoyi/Ammonite/pull/1528

SethTisue commented 1 month ago

Scalameta is failing to extract on JDK 23; this will fix it: https://github.com/scalameta/scalameta/pull/3992

rather than fork temporarily, I'll just hope that gets speedily merged