Restrict this repo to the interface between zinc and a compiler

scala / compiler-interface

a binary contract between Zinc and Scala Compilers

Apache License 2.0

10 stars 4 forks source link

Restrict this repo to the interface between zinc and a compiler #8

Closed lrytz closed 4 years ago

lrytz commented 4 years ago

https://github.com/sbt/compiler-interface/blob/develop/compiler-interface/src/main/java/xsbti/compile/ScalaCompiler.java and most of the types it refers to (Inputs, ScalaCompiler) are not actually an interface between a Scala compiler and zinc, but an interface between Zinc and a build tool.

The two concerns should be separated.

jvican commented 4 years ago

Agreed :+1:, this repository should contain only the strictest java APIs required for incremental compilation. I believe it's very important these two APIs are split up because (a) will make the change a lot easier to understand and (b) will make it easier to evolve these APIs from the Zinc side.