Always show TOC and move it to bottom on mobile

Dieken commented 6 months ago

Fixed issue #925.

Dieken commented 6 months ago

CI failure isn't caused by this PR.

bishabosha commented 6 months ago

hey, sorry I forgot to look at this

bishabosha commented 6 months ago

I think it's not obvious when reading the page that the TOC even exists because it's after everything, maybe users won't scroll far enough to notice it.

perhaps there should be a banner at the top/bottom that links to the TOC? (or a sticky one that follows you as you read e.g. Getting Started guide)

bishabosha commented 6 months ago

still it could be a follow-up PR to add the links, thank you!

Dieken commented 6 months ago

I think it should be more clear how to find the toc on mobile

It’s better to convert the whole table of content into a menu button on narrow screen, touching or clicking the menu button will expand or collapse the table of content.

But that change is too difficult for me, this patch put the toc bottom, it’s already much better now:

the first page is reached from header menu, so it’s fine to not see the toc immediately, actually the toc is too long, it must’t be placed on the top of content.
when finish one chapter, the reader will notice the toc.
if the reader doesn’t jump on chapters, he can just follow the prev/next links, same experience as before, because the toc never shows before the content.

So, it’s good enough for me, very usable now:-)

scala / docs.scala-lang

Always show TOC and move it to bottom on mobile #2969