scala / pickling

Fast, customizable, boilerplate-free pickling support for Scala
lampwww.epfl.ch/~hmiller/pickling
BSD 3-Clause "New" or "Revised" License
831 stars 79 forks source link

New 0.8.0-SNAPSHOT won't compile on 2.10 #119

Closed ccocchi closed 10 years ago

ccocchi commented 10 years ago

Hi,

This commit https://github.com/scala/pickling/commit/018237e1245fdd804e492131b7445480747efd6a seems to have introduce a bug when compiling with 2.10.3. Here's the stacktrace we get:

error] exception during macro expansion:
[error] java.lang.ClassNotFoundException: scala.quasiquotes.QuasiquoteCompat$
[error]     at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
[error]     at java.security.AccessController.doPrivileged(Native Method)
[error]     at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
[error]     at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[error]     at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[error]     at scala.pickling.PickleMacros$class.pickle(Macros.scala:325)
[error]     at scala.pickling.Compat$$anon$4.pickle(Compat.scala:35)
[error]     at scala.pickling.Compat$.PickleMacros_pickle(Compat.scala:36)
[error] exception during macro expansion:
[error] java.lang.ClassNotFoundException: scala.quasiquotes.QuasiquoteCompat$
[error]     at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
[error]     at java.security.AccessController.doPrivileged(Native Method)
[error]     at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
[error]     at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[error]     at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[error]     at scala.pickling.UnpickleMacros$class.pickleUnpickle(Macros.scala:443)
[error]     at scala.pickling.Compat$$anon$7.pickleUnpickle(Compat.scala:53)
[error]     at scala.pickling.Compat$.UnpickleMacros_pickleUnpickle(Compat.scala:54)
xeno-by commented 10 years ago

The problem is here: https://github.com/scala/pickling/blob/2.10.x/project/Build.scala#L171. POM must contain a dependency on org.scalamacros %% quasiquotes. upd. And it doesn't: https://oss.sonatype.org/content/repositories/snapshots/org/scala-lang/scala-pickling_2.10/0.8.0-SNAPSHOT/scala-pickling_2.10-0.8.0-SNAPSHOT.pom.

phaller commented 10 years ago

Thanks for your quick response, Eugene!

ccocchi commented 10 years ago

Adding the dependency manually fix the bug. Thank you for your reactivity!