search

scala / scabot

Scala's PR&CI automation bot
Apache License 2.0
14 stars 14 forks source link

don't run ci for files/directories irrelevant to CI #23

Open adriaanm opened 9 years ago

adriaanm commented 9 years ago

(note that doc/ is relevant to integration build, it's included in scala-dist)

retronym commented 9 years ago

src/intellij src/eclipse

PRs with a "no-ci" label that we could add for other times when we know better.

adriaanm commented 9 years ago

Yep, no-ci could be good, but introduces a sneaky attack vector.

retronym commented 9 years ago

AFAICR, labels can only be added by team members. Of course they can still be the sneaky ones...

adriaanm commented 9 years ago

true, but these days Scabot will likely beat you to building before you can add the label

adriaanm commented 9 years ago

unlike an issue, you can't add a label to a PR on creation

retronym commented 9 years ago

Perhaps it could cancel the builds upon creation of the label.

retronym commented 9 years ago

Not worth overcomplicating things for this use case, though.

adriaanm commented 9 years ago

Sure, but it seems we can catch 90% of the use cases by looking at the changed files, and we all know how hard it is to recall a launched missile :-)

adriaanm commented 9 years ago

For future reference, the commit api can tell you which files changed:

https://github.com/github/developer.github.com/blob/e33f8121defc22215425e8ee2f4ec2169b70bfba/lib/resources.rb#L526