search

scala / scabot

Scala's PR&CI automation bot
Apache License 2.0
14 stars 14 forks source link

Scabot is ignoring a Dotty PR #48

Closed SethTisue closed 9 years ago

SethTisue commented 9 years ago

namely https://github.com/lampepfl/dotty/pull/802

SethTisue commented 9 years ago

the problem is that GithubApi.pullRequestCommits is only returning the first 30 commits:

scala> val c = new scabot.cli.CLI("dotty")
c: scabot.cli.CLI = scabot.cli.CLI@316e30f5

scala> c.await(c.api.pullRequestCommits(802)).size
res2: Int = 30

this PR has more than 30 commits, but Scabot thinks the 30th one is the last one.