search

scala / scabot

Scala's PR&CI automation bot
Apache License 2.0
14 stars 14 forks source link

Make the CLA check configurable and enable it for Dotty #58

Closed smarter closed 8 years ago

SethTisue commented 8 years ago

changes LGTM. I tried to deploy this, to test it, but got bogged down in breakage and under-documentation. I want to sort it out and at least document the current state of things (even if all the automation that should be in place isn't there, I can document what manual steps are needed), but it'll have to wait until next week.

smarter commented 8 years ago

OK, thanks for looking into this!

adriaanm commented 8 years ago

Let's do this, but defer until we have a block of time to do other needed housekeeping as well. We'll also need to update scala-jenkins-infra.

adriaanm commented 8 years ago

infra updated -- note that when there's no checkCLA clause in the config we NPE:

         at scabot.core.Configuration$class.configBoolean$1(Configuration.scala:32)
smarter commented 8 years ago

Thanks!