search

scala / scabot

Scala's PR&CI automation bot
Apache License 2.0
14 stars 14 forks source link

simplify build definition a little bit #72

Closed SethTisue closed 7 years ago

SethTisue commented 7 years ago

using my newfound sbt-fu, thx @dwijnand for the lesson

SethTisue commented 7 years ago

the only thing I'm a bit unsure about here is dropping.dependsOn(gui) // this does the actual aggregation — not sure what that was supposed to mean/do

SethTisue commented 7 years ago

but, we haven't even been using the GUI :-\

dwijnand commented 7 years ago

Note that "gui" depends (transitively) on everything else. So depending on gui (currently) would making you effectively depend on every sub-project.

The comment is confusing.

Try asking early 2015 @adriaanm: https://github.com/scala/scabot/commit/3f46f0deba4f23c1444220e0d384e7cfc6f017a8

Note it used to depend on more before mid 2015 @adriaanm changed it: https://github.com/scala/scabot/pull/35/commits/eb7b978c46310c0d49d78b946228bd83a73bc4ab

SethTisue commented 7 years ago

meh, we can always revise later as needed