search

scala / scabot

Scala's PR&CI automation bot
Apache License 2.0
14 stars 14 forks source link

remove obsolete "review by" feature #75

Closed SethTisue closed 6 years ago

SethTisue commented 6 years ago

the GitHub web UI supports this directly now

SethTisue commented 6 years ago

this will give Scabot more time for leisure activities with her family.

hrhino commented 6 years ago

Don't you need write access to request a reviewer through the UI?

SethTisue commented 6 years ago

Don't you need write access to request a reviewer through the UI?

well...... I think the awareness of the existence of this feature in scabot among people who don't already have the necessary access to use the official GitHub feature is just about zero. it's just another thing for people to learn (and forget, or be confused about) — I really don't think we've have added this feature to begin with if the GitHub feature had existed back then. I think it's better to just go with the GitHub flow unless something is really a pronounced, definite value-add.

SethTisue commented 6 years ago

okay nbd