JDK selection: allow non-Adopt early access builds

scala / scala-dev

Scala 2 team issues. Not for user-facing bugs or directly actionable user-facing improvements. For build/test/infra and for longer-term planning and idea tracking. Our bug tracker is at https://github.com/scala/bug/issues

Apache License 2.0

130 stars 14 forks source link

JDK selection: allow non-Adopt early access builds #780

Closed SethTisue closed 3 years ago

SethTisue commented 3 years ago

so that e.g. at the moment ADOPTOPENJDK=17 will get us 17.ea.28-open (which is just OpenJDK, from Java.net)

I considered taking a more elaborate approach involving additional environment variables, to make this opt-in, but shrug, I actually think it's okay to give someone a non-Adopt build if that's the best we can do

SethTisue commented 3 years ago

I'm trying this out at https://github.com/scala/scala-parser-combinators/pull/407

SethTisue commented 3 years ago

it worked. https://github.com/dwijnand/sbt-extras/issues/326 remains a danger

SethTisue commented 3 years ago

post-merge review by @lrytz, if he wants

lrytz commented 3 years ago

👍