Release Scala 2.13.9 - Githubissues

SethTisue commented 2 years ago

Variables to be expanded in this template (or set and export them in a local terminal, so that you can copy/paste the commands below without replacing anything):

SCALA_VER_BASE="2.13.9"
SCALA_VER_SUFFIX=""
SCALA_SHA=986dcc160aab85298f6cab0bf8dd0345497cdc01
DIST_SHA=ea3c4fe1f729b393a232f1d19b0ec06a27cd28b7
SCALA_VER="$SCALA_VER_BASE$SCALA_VER_SUFFIX"

Key links:

scala/scala milestone: https://github.com/scala/scala/milestones/2.13.9
scala/bug milestone: https://github.com/scala/bug/milestones/2.13.9
scala/scala-dev milestone: https://github.com/scala/scala-dev/milestones/2.13.9
Discourse topic: https://contributors.scala-lang.org/t/scala-2-13-9-release-planning/5693
release notes draft: https://github.com/scala/scala-dev/pull/817

N weeks before the release

[x] Wind down PR queue. There has to be enough time after the last (non-trivial) PR is merged and the next phase. The core of the eco-system needs time to prepare for the final!
[x] Triage scala/bug and scala/scala-dev tickets
[x] Create next scala/scala milestone, move the magical "Merge to 2.13.x" description to it (so Scabot uses it as default for new PRs), move pending PRs
[x] Create next scala/bug milestone, move pending issues
[x] Create next scala/scala-dev milestone, move pending issues
[x] Check PRs assigned to the milestone, also check WIP
[x] Announce expected release date and current nightly "release candidate" (nightly sha-mangled version) at https://scala-ci.typesafe.com/artifactory/scala-integration/ on https://contributors.scala-lang.org/c/announcements
[x] Also notify Scala Center advisory board members of the upcoming release, so they can help test if they want (Seth can handle this, if asked)

Release announcement / notes

[x] Notify community on https://contributors.scala-lang.org/c/announcements
[x] Review merged PRs, make sure release-notes label is applied appropriately
[x] PRs with release-notes label must have excellent title & description (title will be pasted literally in release note bullet list)
[x] Draft release notes (PR and self-merge, so others can comment there rather than on the commits)
- Starting point: gh api --paginate -X GET search/issues -f q='repo:scala/scala is:pull-request is:merged milestone:2.13.9 label:release-notes' -q '.items[] | " * \(.title) ([#\(.number)](\(.html_url)) by [@\(.user.login)](\(.user.html_url)))"'
[x] On contributors thread, link to release note file and request feedback

N days before release

[x] Announce no more PRs will be merged unless last-minute regressions are found. Re-iterate current nightly sha version for testing.
[x] Community build
[x] Windows build on GitHub Actions: https://github.com/scala/scala/actions/runs/2974828042
[x] JDK 17 build on Travis-CI (cron job): https://app.travis-ci.com/github/scala/scala/builds/255110481
[x] Check any merged PRs accidentally assigned to the next milestone in this branch, and re-assign them to this milestone
[x] Merge in any older release branch
[x] Check module versioning (is everything in versions.properties up to date?)
- including make sure the version of scala-asm we're using is using latest ASM
~On major release, bump PickleFormat version~
[x] Close the scala/scala and scala/bug milestones

Point of no return

Once sufficient time for community testing has passed, it's time to cut the release!

What is "sufficient" time? A week is a bare minimum. Two weeks is a better "normal" amount. We should also respect requests from Scala Center advisory board members, if they explicitly ask for additional testing time. (In the past, we sometimes only waited a day or two, but this was overly optimistic in presuming that people had been testing nightlies all along.)

Be mindful of others' schedules; even minor releases make work downstream (for Scala.js and Scala Native, for the Scala 3 team, for compiler plugin authors, and so on). And a botched release might make unexpected work for ourselves as well as for others. So it's better not to release on a Friday or even a Thursday, or too close to a major holiday. And it's best to release while everyone in both America and Europe is awake. (First thing in the morning in America is a good choice.)

[x] Make sure there are no stray staging repos on Sonatype
[x] Trigger a custom build on travis
- Select the correct branch
- Custom config: before_script: export SCALA_VER_BASE=2.13.9 SCALA_VER_SUFFIX=
- https://app.travis-ci.com/github/scala/scala/builds/255729193
- Check the build status on https://github.com/scala/scala/commits/2.13.x
- Check that the scala/scala job also triggered a following scala/scala-dist job: https://app.travis-ci.com/github/scala/scala-dist/builds/?
- [x] Create the scala/scala tag locally: git tag -s -m "Scala $SCALA_VER" v$SCALA_VER $SCALA_SHA
- [x] Create scala-dist tag locally: git tag -s -m "Scala $SCALA_VER" v$SCALA_VER $DIST_SHA
- [x] Note the repos to be promoted after tag is cut (see travis log)
- https://oss.sonatype.org/content/repositories/orgscala-lang-3153
- https://oss.sonatype.org/content/repositories/orgscala-lang-3154
- https://oss.sonatype.org/content/repositories/orgscala-lang-3155
- https://oss.sonatype.org/content/repositories/orgscala-lang-3156
[x] Sanity check jar/pom
- https://oss.sonatype.org/content/repositories/staging/org/scala-lang/scala-compiler/2.13.9/
- in particular, if the release was staged multiple times, double check that https://oss.sonatype.org/content/repositories/staging/ has the files from the most recent build
[x] Check that JARs haven't mysteriously bloated — compare sizes to previous release. We have no other backstop for this.
Remember, tags are forever, so are maven artifacts (even staged ones, as they could end up in local caches) and S3 uploads (S3 buckets can be changed, but it can takes days to become consistent)
[x] Push scala/scala tag: git push https://github.com/scala/scala.git v2.13.9
[x] Push scala/scala-dist tag: git push https://github.com/scala/scala-dist.git v2.13.9
[x] Trigger two scala-dist jobs on travis (https://app.travis-ci.com/github/scala/scala-dist) with custom config. must use full-length SHAs!
- before_script: export version=2.13.9 scala_sha=986dcc160aab85298f6cab0bf8dd0345497cdc01 mode=archives: https://app.travis-ci.com/github/scala/scala-dist/builds/?
- before_script: export version=2.13.9 scala_sha=986dcc160aab85298f6cab0bf8dd0345497cdc01 mode=update-api: https://app.travis-ci.com/github/scala/scala-dist/builds/?
[x] Promote staging repos: st_stagingRepoPromote [scala-repo], st_stagingRepoPromote [modules-repo] (or use oss.sonatype.org web UI)

Check availability

[x] Check release on sonatype: https://oss.sonatype.org/content/repositories/releases/org/scala-lang/scala-compiler/2.13.9/
[x] Check the release on maven central: https://repo1.maven.org/maven2/org/scala-lang/scala-compiler/2.13.9/

When everything is on maven central

NOTE (Mar 2 2022): at next release time, update these steps as needed to accomodate https://github.com/scala/scala-lang/pull/1344

[x] Prepare PR to https://github.com/scala/scala-lang/ (using scala/make-release-notes which requires a staged release and a pushed tag)
- download/index.md
- _config.yml (update devscalaversion or scalaversion)
- index.md (update currentScalaVersion)
[x] Prepare PR to https://github.com/scala/docs.scala-lang/
- api/all.md, _config.yml, _overviews/jdk-compatibility/overview.md
- also consider updating https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html
[x] Pre-announce the release on https://contributors.scala-lang.org/c/announcements
[x] ~On major releases only: (manually) update the current symlink for the API docs~
- ~https://github.com/scala/scala-dist/blob/2.13.x/scripts/jobs/release/website/update-api#L15~
[x] Check that the API docs are published
- https://www.scala-lang.org/api/ should have new version
- if they don't show up, possible troubleshooting steps include:
- review the two scala-dist job logs to make sure that
  - the first one appears to have succeeded putting files in /home/linuxsoft/archives/scala/api on chara.epfl.ch
  - the second one appears to have succeeded in updating the symlink (from 2.1x.y to $SCALA_VER)
- ssh to chara.epfl.ch and poke around to see if things are where they should be
  - if you don't have the credential for this locally but you are able to bring jenkins-worker-publish up at ssh jenkins-worker-publish, then from there you can ssh -i ~/.ssh/jenkins_lightbend_chara scalatest@chara.epfl.ch
- see if https://scala-webapps.epfl.ch/jenkins/view/All/job/production_scala-lang.org-scala-dist-archive-sync/ has run a job yet to sync the changes into production
  - if not, you can manually trigger a job. Seth has access to do that, probably others on the team do too. if we get stuck, Fabien can help

Prepare downstream

[x] ~Create PR to add/update spec links on scala-lang.org (example: https://github.com/scala/scala-lang/pull/1050)~
[x] ~build and release scala-collection-compat and other modules (or open tickets asking that the maintainers do so)~
- ~this work has moved to https://github.com/scala/make-release-notes/blob/2.13.x/projects-2.13.md~
[x] if it's a 2.12.x release, publish macro paradise for the new version
Open tickets in these repos, requesting publishing:
- [x] typelevel/kind-projector
- [x] scalameta
- [x] scalafix
- [x] scoverage
- [x] silencer
- [x] wartremover
- [x] acyclic
- [x] Ammonite
- [x] (Lightbend) lightbend/genjavadoc

Wait for downstream

Before proceeding any further, wait for the ecosystem to catch up.

Downstream publishing:
- [x] Wait for Scala.js to support the new release
- [x] Wait for Scala Native to support the new release
- [x] Wait for scalameta to publish
- [x] Wait for scalafix to publish
- [x] Wait for Metals to publish
- [x] Wait for kind-projector to publish
- [x] Wait for scoverage to publish
Downstream signoffs:
- [x] Wait for the Scala Center to sign off (Seb)
- [x] Wait for VirtusLab to sign off (Krzysztof)

We have promised to wait 48 non-weekend hours, minimum.

If there are delays downstream, at some point it may make sense to go ahead and announce anyway, since news of the release will already be spreading in the community.

Announcements

[x] On GitHub, use "Create release from tag" button and add release notes
- https://github.com/scala/scala/releases/tag/v$SCALA_VER
[x] Merge the scala-lang PR and the docs.scala-lang.org PR
- [x] wait for them to arrive on the websites and make sure they look okay
- if the scala-lang changes don't show up, possible troubleshooting steps include:
  - see if https://scala-webapps.epfl.ch/jenkins/view/All/job/production_scala-lang.org-builder/ has run a job yet to actually publish the changes
  - see note above about permissions to trigger a job
[x] Scala Users discourse https://users.scala-lang.org
[x] Tweet from @scala_lang
[x] Discord: link to release notes in #announcements channel
- [x] consider also saying something in #scala-contributors channel
[x] Unblock the release in Scala Steward by PRing an update to default.scala-steward.conf
[x] Add the release to SDKMAN
- as per the documentation at https://sdkman.io/vendors
- URL provided must be in .zip format, .tgz doesn't work
- sample command: curl -X POST -H "Consumer-Key: xxx" -H "Consumer-Token: xxx" -H "Content-Type: application/json" -H "Accept: application/json" -d '{"candidate": "scala", "version": "2.12.14", "url": "https://downloads.lightbend.com/scala/2.12.14/scala-2.12.14.tgz"}' https://vendors.sdkman.io/release
- replace both xxxs with the credential information provided to Seth by Marco Vermeulen (marco at sdkman dot io)
- [x] test afterwards with sdk list scala and sdk install scala <version> (these should work immediately once the POST succeeds)
- to correct mistakes, PATCH and DELETE are also available
- [x] broadcast the addition via the SDKMAN twitter account
- sample command: `curl -X POST -H "Consumer-Key: xxx" -H "Consumer-Token: xxx" -H "Content-Type: application/json" -H "Accept: application/json" -d '{"candidate": "scala", "version": "2.12.14", "url": "https://github.com/scala/scala/releases/tag/v2.12.14"}' https://vendors.sdkman.io/announce/struct
[x] Announce on https://reddit.com/r/scala
[x] ask Seth to announce on #scala IRC

Afterwards

[x] Scala 3: open PR updating version:
- two places to update:
- project/Build.scala
- community-build/community-projects/stdLib213 (after updating https://github.com/dotty-staging/scala to include recent commits)
- https://github.com/lampepfl/dotty/pulls
[x] Scastie: open PR adding new version (modeled on https://github.com/scalacenter/scastie/pull/538)
- note that the PR won't be mergeable until kind-projector has published; and if kind-projector's version number has changed, ScalaTarget.scala will need updating
~If it's a major release:~
- ~Update latestSpecVersion in spec/_config.yml on the old branch, so that spec is marked as no longer current~
- ~Ditto for the nightly build and spec links in _data/footer.yml and _data/doc-nav-header.yml on docs.scala-lang.org~
[x] Create PR to update https://github.com/lightbend/lightbend-technology-intro-doc/blob/master/docs/modules/getting-help/pages/build-dependencies.adoc
(Lightbend) Fortify:
- [x] Publish scala-fortify-plugin
- [x] Update scala-fortify
- [x] Update scala-fortify-docs
[x] (Lightbend) Update whatever we replaced WhiteSource with, if anything?
[x] (Lightbend) Notify eng-updates
[x] Update https://contributors.scala-lang.org thread
[x] Create a scala/scala PR to:
- [x] update starr.version in /versions.properties
- [x] update Global / baseVersion in /build.sbt
- [x] update mimaReferenceVersion in /project/MimaFilters.scala
- [x] clear out mimaFilters in /project/MimaFilters.scala, except the one(s) labeled "KEEP"
- ~spec/_config.yml, if it's a major release~

You're done!

[x] Close this ticket and close the scala-dev milestone

SethTisue commented 2 years ago

all the todo items before the "Point of no return" are now complete

SethTisue commented 1 year ago

The release job went fine except that the scala-dist jobs it triggered failed early because apt-get update failed:

W: The repository 'http://apt.postgresql.org/pub/repos/apt xenial-pgdg Release' does not have a Release file.
217E: Failed to fetch http://apt.postgresql.org/pub/repos/apt/dists/xenial-pgdg/main/binary-amd64/Packages  404  Not Found [IP: 87.238.57.227 80]
218E: Some index files failed to download. They have been ignored, or old ones used instead.

I merged https://github.com/scala/scala-dist/pull/220 and re-ran the release job with the sole purpose of re-triggering the scala-dist jobs. (It will also create staging repos on Sonatype, but I'll just drop them.)