search

scala / scala-dev

Scala 2 team issues. Not for user-facing bugs or directly actionable user-facing improvements. For build/test/infra and for longer-term planning and idea tracking. Our bug tracker is at https://github.com/scala/bug/issues
Apache License 2.0
130 stars 14 forks source link

The most infamous flaky test #840

Open som-snytt opened 1 year ago

som-snytt commented 1 year ago

https://github.com/scala/scala/pull/10105#issuecomment-1520804441

presentation/doc sees Unexpected foo method comment: None.

Personally, I am surprised that foo requires comment.

Parking it here as internal.

som-snytt commented 7 months ago

https://github.com/scala/scala/pull/10732#issuecomment-2048910081

and

https://github.com/scala/scala/pull/10732#issuecomment-2056303151

lrytz commented 3 months ago

i saw it locally 👻

som-snytt commented 3 months ago

Duplicates https://github.com/scala/scala-dev/issues/72 !

I corrected the title.

lrytz commented 3 months ago

Looking at the code, the None probably originates here: https://github.com/scala/scala/blob/2d9e6acce8c4246e6cba5a22ff9d965ec3bd117c/src/interactive/scala/tools/nsc/interactive/Response.scala#L68

response.get is called here https://github.com/scala/scala/blob/53e1571071bf75ce6ddd6e7b4f0b84ef1bdc32f8/test/files/presentation/doc/doc.scala#L65

som-snytt commented 2 months ago

Sometimes I have a hankering for a large plate of spaghetti.