Closed SethTisue closed 2 months ago
It might be worth mentioning that the 5 fake source files of library-aux
are now part of the sources jar. It can impact tools that use the source jar in a meaningful way. For example the Scala.js build needs to explicitly exclude those files using
scalalibInternal.v2_13/Compile/sources ~= {
val excludes = Set("Any.scala", "AnyRef.scala", "Nothing.scala", "Null.scala", "Singleton.scala")
prev => prev.filterNot(f => f.getParentFile.getName == "scala" && excludes.contains(f.getName))
}
I wonder if IDEs will actually be able to deal with those or if they will panic. Have we checked with IntelliJ and Metals?
IntelliJ was tested (https://github.com/scala/scala/pull/10714), including the sources was actually a request that came through IntelliJ (https://youtrack.jetbrains.com/issue/SCL-22167).
For metals I tried a small sbt project with
resolvers += "scala-integration" at "https://scala-ci.typesafe.com/artifactory/scala-integration/"
ThisBuild / scalaVersion := "2.13.14-bin-a527019"
While I can navigate to Unit
for example
I cannot navigate to the new sources like AnyRef / Null.
@tgodzik is that worth a ticket?
We might need to first release metals for that versions, which requires semanticdb. We can confirm once everything is out.
If anyone is trying out -Xsource-features
, be sure and look at the doc revisions at https://github.com/scala/docs.scala-lang/pull/2994 — the PR will be merged at announcement time.
rendered: https://github.com/SethTisue/scala-dev/blob/scala-2.13.14/releases/2.13.14.md
feedback welcome