search

scala / scala-lang

sources for the Scala language website
https://scala-lang.org
Other
274 stars 320 forks source link

scala.js snippet on frontpage is broken #1667

Closed OlegYch closed 4 months ago

OlegYch commented 4 months ago

running https://scastie.scala-lang.org/gyNudjdITL2irc9ni0kRxA fails with

org.scalajs.ir.IRVersionNotSupportedException: Failed to deserialize a file compiled with Scala.js 1.16 (supported up to: 1.13): /home/sbtRunnerContainer/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-js/scalajs-library_2.13/1.16.0/scalajs-library_2.13-1.16.0.jar:/scala/scalajs/LinkingInfo.sjsir
You may need to upgrade the Scala.js sbt plugin to version 1.16 or later.
sjrd commented 4 months ago

@rochala Looks like Scastie needs to bump its Scala.js version to 1.16.0. Are you still in charge of Scastie?

rochala commented 4 months ago

Are you still in charge of Scastie?

I'm still trying to maintain it. I'll redeploy it today

OlegYch commented 4 months ago

@sjrd i think it's a matter of creating a new snippet and updating the link

rochala commented 4 months ago

It seems that Scala.js is already at 1.16, @OlegYch is right. It seems like changing a versions doesn't update Scala.js plugin version in configuration so there is a bug indeed. To update sbt plugin version you need to switch target to e.g jvm and then back to JS

This is the new link working on latest LTS with latest library versions. https://scastie.scala-lang.org/CQ70LFpbRJuWEDfGxbuYeQ

sjrd commented 4 months ago

Thanks for the link! PR to include it at #1668.

rochala commented 4 months ago

The long term solution for this, would be adding a support for github organisations to login to Scastie, and then migrate all snippets there. We could then modify snippets, without the need for PR