search

scala / scala-lang

sources for the Scala language website
https://scala-lang.org
Other
274 stars 320 forks source link

fallback to 'monospace' for code font-family #1674

Closed cjbayliss closed 2 months ago

cjbayliss commented 2 months ago

Some people like myself disable custom fonts on the web. The reasons are often related to accesibility. In my case it is dyslexia, but there are probably other vision related reasons too.

SethTisue commented 2 months ago

looks plausible, but I don't know CSS myself — were you able to test it?

cjbayliss commented 2 months ago

I did test it, however there is no need to take my word for it. MDM has a very easy to follow document on font-family: https://developer.mozilla.org/en-US/docs/Web/CSS/font-family

Two relevant quotes:

"The font-family property specifies a list of fonts, from highest priority to lowest."

and:

"You should always include at least one generic family name in a font-family list, since there's no guarantee that any given font is available. This lets the browser select an acceptable fallback font when necessary."

I'm not a CSS person, I'm not even a front-end dev. I love Mozilla's MDM, and can highly recommend it whenever you need info on a CSS property or anything related to Javascript.

Another very useful resource if you need to check if a PR is safe to merge is caniuse.com: https://caniuse.com/mdn-css_properties_font-family

These two resources make it so that people like us who don't know CSS well can easily contribute and review CSS changes.

Sorry for the tangent. 😅 I hope it is helpful for future reference :)

SethTisue commented 2 months ago

Thank you!