search

scala / scala-library-next

backwards-binary-compatible Scala standard library additions
Apache License 2.0
69 stars 17 forks source link

Add scalafmt #37

Open NthPortal opened 3 years ago

NthPortal commented 3 years ago

could probably use a check in the CI pipeline, but I don't know how

SethTisue commented 3 years ago

I don't mind having build.sbt be auto-formatted, but I don't see much advantage in it either, and I think it would actually be kind of annoying if PR validation failed just because of a whitespace difference in build.sbt

hmm. were you thinking we should do this in src/main and src/test as well? I see more value there (I'm not actually enthusiastic about it, but not opposed either)

NthPortal commented 3 years ago

the configuration had better be such that formatting matches the upstream scala repo

the upstream repo is entirely manually formatted, so I don't think that will be an issue

martijnhoekstra commented 3 years ago

You tagged this as help wanted, I assume with CI checking the fmt? I made a PR for that against this PR.