`NoSuchElementException: val` raised by simple quotes

cchantep commented 2 years ago

Compiler version

3.1.2-RC1-bin-20211022-f7abd32-NIGHTLY

Minimized code

// res: Try[_]
'{
  val v = ${ res }.get

  println("v=" + v)
}

See code

Output

Compilation exception

java.util.NoSuchElementException: val v$8

``` scala.collection.mutable.AnyRefMap$ExceptionDefault.apply(AnyRefMap.scala:508) scala.collection.mutable.AnyRefMap$ExceptionDefault.apply(AnyRefMap.scala:507) scala.collection.mutable.AnyRefMap.apply(AnyRefMap.scala:207) dotty.tools.backend.jvm.BCodeSkelBuilder$PlainSkelBuilder$locals$.load(BCodeSkelBuilder.scala:508) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoad(BCodeBodyBuilder.scala:415) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoadArguments(BCodeBodyBuilder.scala:1127) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genApply(BCodeBodyBuilder.scala:772) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoad(BCodeBodyBuilder.scala:361) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoad(BCodeBodyBuilder.scala:285) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoadQualifier(BCodeBodyBuilder.scala:1111) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genApply(BCodeBodyBuilder.scala:771) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoad(BCodeBodyBuilder.scala:361) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoad(BCodeBodyBuilder.scala:285) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoadQualifier(BCodeBodyBuilder.scala:1111) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genTypeApply(BCodeBodyBuilder.scala:638) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoad(BCodeBodyBuilder.scala:452) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoad(BCodeBodyBuilder.scala:305) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genStat(BCodeBodyBuilder.scala:111) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genBlock$$anonfun$1(BCodeBodyBuilder.scala:1019) scala.runtime.function.JProcedure1.apply(JProcedure1.java:15) scala.runtime.function.JProcedure1.apply(JProcedure1.java:10) scala.collection.immutable.List.foreach(List.scala:333) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genBlock(BCodeBodyBuilder.scala:1019) dotty.tools.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoad(BCodeBodyBuilder.scala:432) dotty.tools.backend.jvm.BCodeSkelBuilder$PlainSkelBuilder.emitNormalMethodBody$1(BCodeSkelBuilder.scala:766) dotty.tools.backend.jvm.BCodeSkelBuilder$PlainSkelBuilder.genDefDef(BCodeSkelBuilder.scala:801) dotty.tools.backend.jvm.BCodeSkelBuilder$PlainSkelBuilder.gen(BCodeSkelBuilder.scala:609) dotty.tools.backend.jvm.BCodeSkelBuilder$PlainSkelBuilder.gen$$anonfun$1(BCodeSkelBuilder.scala:615) scala.runtime.function.JProcedure1.apply(JProcedure1.java:15) scala.runtime.function.JProcedure1.apply(JProcedure1.java:10) scala.collection.immutable.List.foreach(List.scala:333) dotty.tools.backend.jvm.BCodeSkelBuilder$PlainSkelBuilder.gen(BCodeSkelBuilder.scala:615) dotty.tools.backend.jvm.BCodeSkelBuilder$PlainSkelBuilder.genPlainClass(BCodeSkelBuilder.scala:230) dotty.tools.backend.jvm.GenBCodePipeline$Worker1.visit(GenBCode.scala:259) dotty.tools.backend.jvm.GenBCodePipeline$Worker1.run(GenBCode.scala:224) dotty.tools.backend.jvm.GenBCodePipeline.buildAndSendToDisk(GenBCode.scala:559) dotty.tools.backend.jvm.GenBCodePipeline.run(GenBCode.scala:525) dotty.tools.backend.jvm.GenBCode.run(GenBCode.scala:63) dotty.tools.dotc.core.Phases$Phase.runOn$$anonfun$1(Phases.scala:308) scala.collection.immutable.List.map(List.scala:246) dotty.tools.dotc.core.Phases$Phase.runOn(Phases.scala:309) dotty.tools.backend.jvm.GenBCode.runOn(GenBCode.scala:71) dotty.tools.dotc.Run.runPhases$1$$anonfun$1(Run.scala:261) scala.runtime.function.JProcedure1.apply(JProcedure1.java:15) scala.runtime.function.JProcedure1.apply(JProcedure1.java:10) scala.collection.ArrayOps$.foreach$extension(ArrayOps.scala:1323) dotty.tools.dotc.Run.runPhases$1(Run.scala:272) dotty.tools.dotc.Run.compileUnits$$anonfun$1(Run.scala:280) scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18) dotty.tools.dotc.util.Stats$.maybeMonitored(Stats.scala:68) dotty.tools.dotc.Run.compileUnits(Run.scala:289) dotty.tools.dotc.Run.compileUnits(Run.scala:228) dotty.tools.dotc.Driver.finish(Driver.scala:60) dotty.tools.dotc.Driver.doCompile(Driver.scala:40) dotty.tools.xsbt.CompilerBridgeDriver.run(CompilerBridgeDriver.java:88) dotty.tools.xsbt.CompilerBridge.run(CompilerBridge.java:22) sbt.internal.inc.AnalyzingCompiler.compile(AnalyzingCompiler.scala:91) sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compile$7(MixedAnalyzingCompiler.scala:192) scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23) sbt.internal.inc.MixedAnalyzingCompiler.timed(MixedAnalyzingCompiler.scala:247) sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compile$4(MixedAnalyzingCompiler.scala:182) sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compile$4$adapted(MixedAnalyzingCompiler.scala:163) sbt.internal.inc.JarUtils$.withPreviousJar(JarUtils.scala:239) sbt.internal.inc.MixedAnalyzingCompiler.compileScala$1(MixedAnalyzingCompiler.scala:163) sbt.internal.inc.MixedAnalyzingCompiler.compile(MixedAnalyzingCompiler.scala:210) sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1(IncrementalCompilerImpl.scala:528) sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1$adapted(IncrementalCompilerImpl.scala:528) sbt.internal.inc.Incremental$.$anonfun$apply$5(Incremental.scala:175) sbt.internal.inc.Incremental$.$anonfun$apply$5$adapted(Incremental.scala:173) sbt.internal.inc.Incremental$$anon$2.run(Incremental.scala:459) sbt.internal.inc.IncrementalCommon$CycleState.next(IncrementalCommon.scala:116) sbt.internal.inc.IncrementalCommon$$anon$1.next(IncrementalCommon.scala:56) sbt.internal.inc.IncrementalCommon$$anon$1.next(IncrementalCommon.scala:52) sbt.internal.inc.IncrementalCommon.cycle(IncrementalCommon.scala:263) sbt.internal.inc.Incremental$.$anonfun$incrementalCompile$8(Incremental.scala:414) sbt.internal.inc.Incremental$.withClassfileManager(Incremental.scala:501) sbt.internal.inc.Incremental$.incrementalCompile(Incremental.scala:401) sbt.internal.inc.Incremental$.apply(Incremental.scala:167) sbt.internal.inc.IncrementalCompilerImpl.compileInternal(IncrementalCompilerImpl.scala:528) sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileIncrementally$1(IncrementalCompilerImpl.scala:482) sbt.internal.inc.IncrementalCompilerImpl.handleCompilationError(IncrementalCompilerImpl.scala:332) sbt.internal.inc.IncrementalCompilerImpl.compileIncrementally(IncrementalCompilerImpl.scala:420) sbt.internal.inc.IncrementalCompilerImpl.compile(IncrementalCompilerImpl.scala:137) sbt.Defaults$.compileIncrementalTaskImpl(Defaults.scala:2357) sbt.Defaults$.$anonfun$compileIncrementalTask$2(Defaults.scala:2314) sbt.internal.io.Retry$.apply(Retry.scala:46) sbt.internal.io.Retry$.apply(Retry.scala:28) sbt.internal.io.Retry$.apply(Retry.scala:23) sbt.internal.server.BspCompileTask$.compute(BspCompileTask.scala:31) sbt.Defaults$.$anonfun$compileIncrementalTask$1(Defaults.scala:2310) scala.Function1.$anonfun$compose$1(Function1.scala:49) sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62) sbt.std.Transform$$anon$4.work(Transform.scala:68) sbt.Execute.$anonfun$submit$2(Execute.scala:282) sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:23) sbt.Execute.work(Execute.scala:291) sbt.Execute.$anonfun$submit$1(Execute.scala:282) sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265) sbt.CompletionService$$anon$2.call(CompletionService.scala:64) java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:514) java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) java.base/java.lang.Thread.run(Thread.java:844) ```

Expectation

No error

nicolasstucki commented 2 years ago

Minimizing the code in the link above would be a good spree task

nob13 commented 1 year ago

Hi, I stumbled on the same problem when generating Macros for some RPC Service.

Here is a minimal crashing example: https://github.com/nob13/dottybug13955 using Scala 3.2.1

The crashing line is the val inside the generated method content in https://github.com/nob13/dottybug13955/blob/1795ff73cec62f7a93f939c8092457151052129c/src/main/scala/Adder.scala#L40

If the method returns without result, everything works fine.

nob13 commented 1 year ago

Note: Declaring value using ValDef.let works. Maybe val shouldn't be present in Quotes?

nob13 commented 1 year ago

Update: The problem was a missing given Quotes = decl.asQuotes, which can be shown when -Xcheck-macros is activated.

Updated the referenced Github Example, this works now.

mbovel commented 1 month ago

Update: The problem was a missing given Quotes = decl.asQuotes, which can be shown when -Xcheck-macros is activated.

Updated the referenced Github Example, this works now.

Nice! So can we close this issue, or is there a problem left to solve?

He-Pin commented 1 month ago

At least the error message can be improved

scala / scala3