Open som-snytt opened 1 week ago
Further tweaks forthcoming.
@som-snytt how much work do you think it still requires? It seems we might want to backport the fix for #20860 to 3.5.0 at the very least... do you need any help?
I'll submit commit 2 separately, as I was about to do except it's one line.
I'll follow up the fix for commit 1 after the American holiday.
The previous test fails were because the new prefix check (in isInImport
) doesn't apply when isDerived
and also for top-level defs where the prefix becomes a package object (not sure if that =:=
test should work, or if there's a convenient idiom, or if the check is even useful). The derived check uses dealiased types, not sure if a better mechanism is warranted.
I'll clean up and also look for improvements.
Fixes #19657