search

scala / scala3

The Scala 3 compiler, also known as Dotty.
https://dotty.epfl.ch
Apache License 2.0
5.73k stars 1.04k forks source link

Fix failing `CompletionScalaCliSuite` tests due to circe releasing Scala Native 0.5 artifacts #20931

Closed WojciechMazur closed 2 weeks ago

WojciechMazur commented 2 weeks ago

The recent release of circe for SN 0.5 changed the outputs of CompletionScalaCli suite. The PR fixes failing tests

WojciechMazur commented 2 weeks ago

We should find a better way to handle this kind of completions.

Agree. It's just a fast fix although it seems that presentation compiler is not tested in the CI (I think so), but it started to fail locally. In such case if it's not blocking CI we can take time to make a better solution

WojciechMazur commented 2 weeks ago

Surprisingly the CI failed in all of the modified tests. We would need to check why it behaves differently locally and in the CI

tgodzik commented 2 weeks ago

Surprisingly the CI failed in all of the modified tests. We would need to check why it behaves differently locally and in the CI

That is highly surprising, this is basically cs complete-dep and its' output seems to work

We should find a better way to handle this kind of completions.

@tgodzik Coursier is quite big dependency and we only use it for this purpose. Maybe we could change the interface in a way that allows us to provide a handler for this kind of completions, and move away logic form the presentation compiler ?

We could add that to SymbolSearch interface, it would probably make sense and just mock it, test it inside metals

tgodzik commented 2 weeks ago

If needed you can ignore the tests for now.

hamzaremmal commented 2 weeks ago

Blocking #20837