search

scala / toolkit

The batteries-included Scala
https://docs.scala-lang.org/toolkit/introduction.html
86 stars 12 forks source link

os-lib 0.10.2, upickle 3.3.1 #53

Closed sideeffffect closed 1 month ago

sideeffffect commented 1 month ago

fixes #52

bishabosha commented 1 month ago

im not sure how it works, but you also need to generate the changelog files

bishabosha commented 1 month ago

ok please can you also run scala-cli changelog -- --overwrite which generates the new changelogs

bishabosha commented 1 month ago

@adpi2 are you meant to update the changelogs in a PR like this, or only when we make a new tag?

adpi2 commented 1 month ago

In any PR that changes the dependencies.

sideeffffect commented 1 month ago

I think it's very suspicious that it's taking this long and that there are OutOfMemory errors from Coursier... Could some Toolkit maintainer have a look at this, please? :pray: @bishabosha or @adpi2 ?

bishabosha commented 1 month ago

@adpi2 knows more about this but is on vacation

sideeffffect commented 1 month ago

@adpi2 ping :smile_cat:

adpi2 commented 1 month ago

I'll be back to work tomorrow. Thanks for your patience.

sideeffffect commented 1 month ago

Is there a reason why it's not on Maven Central yet? https://repo1.maven.org/maven2/org/scala-lang/toolkit_native0.5_3/

The job seems to have finished successfully https://github.com/scala/toolkit/actions/runs/10246371483/job/28343314234

sideeffffect commented 1 month ago

Actually it failed, yet everything is green :scream_cat: 

Uploading files failed!
Possible causes:
- incorrect Sonatype credentials
- incorrect Sonatype server was used, try 'central-s01'
 -> consult publish subcommand documentation

https://github.com/scala/toolkit/actions/runs/10246371483/job/28343314234#step:11:120

adpi2 commented 1 month ago

Actually it failed, yet everything is green 🙀

Oh thanks for catching that. I think it is an issue with the Sonatype credentials and I am going to try again.

lbialy commented 1 month ago

@Gedochao hey, have you seen this? Looks like it's not only mill then.

Gedochao commented 1 month ago

@Gedochao hey, have you seen this? Looks like it's not only mill then.

The error is different, though. It's likely the Sonatype creds issue everyone had last week. Might be sufficient to regenerate the token.

adpi2 commented 1 month ago

The error is different, though. It's likely the Sonatype creds issue everyone had last week. Might be sufficient to regenerate the token.

Yes that's what I did. Let's see if it fixes the release.

adpi2 commented 1 month ago

It's working better now: https://oss.sonatype.org/content/repositories/public/org/scala-lang/toolkit_2.13/0.5.0/

sideeffffect commented 1 month ago

https://github.com/com-lihaoyi/mill#0-11-11

sideeffffect commented 1 month ago

What bout the fact that failed publish didn't cause the CI to fail/become red? Is that an issue with the CI setup of this repository? Or an issue with Mill?

adpi2 commented 1 month ago

Is that an issue with the CI setup of this repository? Or an issue with Mill?

That's a good question. It could be that we have continue-on-error: true in our workflow for some historical reason. But I think we can remove it now.

https://github.com/scala/toolkit/pull/58