scalability4all / voice-enabled-chatbot

Implementing a voice enabled chatbot which converses with a user via their voice in natural language. Website: https://scalability4all.github.io/
MIT License
38 stars 52 forks source link

Intent classification #45

Closed poojithamiryala closed 4 years ago

pep8speaks commented 4 years ago

Hello @poojithamiryala! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-04-25 14:48:26 UTC
satyammittal commented 4 years ago

A) Can you only keep changes only related to intent classification. like you can remove .idea folder.

B) Please fix pep8 issues.

poojithamiryala commented 4 years ago

Removed .idea folder and resolved pip8 issues

satyammittal commented 4 years ago

looks good.

can you integrate this with current chatbot.py.

pravalikavis commented 4 years ago

So to integrate to chatbot.py do we need to train all the categories or use our model to decide whether it is music/weather/restaurant/None, and if it gives none we continue the normal flow of else if.

satyammittal commented 4 years ago

@pravalikavis Yes, this approach looks fine for initial start.

poojithamiryala commented 4 years ago

Integrated intent classification file with the chatbot

satyammittal commented 4 years ago

@poojithamiryala Please fix the pep8 issues.

poojithamiryala commented 4 years ago

Fixed pep8 issues

satyammittal commented 4 years ago

@poojithamiryala I could still see some code space issues listed by our code style saviour @pep8speaks . Please pull latest changes again as I recently merged a new change. Thanks.

poojithamiryala commented 4 years ago

I tried fixing most of the pep8 issues . Can u please have a look and tell me if there are any?

satyammittal commented 4 years ago

@poojithamiryala can you pull latest changes and fix conflicts.

satyammittal commented 4 years ago

@poojithamiryala can you replace json files with json.zip. and read zip files instead. https://stackoverflow.com/questions/40824807/reading-zipped-json-files

poojithamiryala commented 4 years ago

I have compressed JSON files and read data using zip files .

satyammittal commented 4 years ago

Nice start.