scalable-react / scalable-react-boilerplate

:star: Scalable feature-first React micro-framework made for Udacity Alumni collaborative projects
https://scalable-react-boilerplate.herokuapp.com/
MIT License
259 stars 60 forks source link

null prop `name` is marked required in `LandingContainer` #86

Closed monte-hayward closed 7 years ago

monte-hayward commented 7 years ago

This warning appears whether or not name is supplied.

e.g. name "landing" is added:

scalable-react-boilerplate/app/src/pages/LandingPage/index.js:
    6  const LandingPage = () => (
    7    <div className={styles.container}>
    8:     <LandingContainer name="landing" />
    9    </div>
   10  );
Warning: Failed prop type: The prop `name` is marked as required in `LandingContainer`, but its value is `null`.
    in LandingContainer (created by ReduxForm(LandingContainer))
    in ReduxForm(LandingContainer) (created by Connect(ReduxForm(LandingContainer)))
    in Connect(ReduxForm(LandingContainer)) (created by ReduxFormConnector(LandingContainer))
    in ReduxFormConnector(LandingContainer) (created by ConnectedForm)
    in ConnectedForm (created by Connect(ConnectedForm))
    in Connect(ConnectedForm) (created by LandingPage)
    in div (created by LandingPage)
    in LandingPage (created by RouterContext)
    in div (created by App)
    in App (created by AppContainer)
    in AppContainer (created by AppContainer)
    in AppContainer (created by Connect(AppContainer))
    in Connect(AppContainer) (created by RouterContext)
    in RouterContext (created by Router)
    in Router (created by RouterApp)
    in ApolloProvider (created by RouterApp)
    in RouterApp
RyanCCollins commented 7 years ago

It looks like that prop should not be required since it is null to begin with. Thanks for letting us know, I will get that updated!

RyanCCollins commented 7 years ago

I think this has been resolved on Master. Thanks again!

JawsomeJason commented 7 years ago

Still receiving this:

ERROR in ./app/src/containers/LandingContainer/index.js

/Users/jasonf/workspace/scalable-react-boilerplate/app/src/containers/LandingContainer/index.js
  152:3  error  propType "name" is not required, but has no corresponding defaultProp declaration  react/require-default-props

✖ 1 problem (1 error, 0 warnings)

 @ ./app/src/containers/index.js 12:25-54
 @ ./app/src/routes.js
 @ ./app/src/index.js
 @ multi react-hot-loader/patch webpack-dev-server/client?http://localhost:1337 webpack/hot/only-dev-server ./app/src