Closed adai183 closed 8 years ago
Just two little things, if possible let's try to write tests for our examples and fill in the readme. Also, the React-router link component will automatically add an active class if you set it up correctly. Otherwise, we can use the location api to do something similar.
Nice work and thanks for submitting!!
Hey, sorry just one more thing, which you probably know already (figured I'd mention if not.) You can use ES6 Destructuring for importing multiple components from Grommet.
i.e.
import {
Header,
Title,
Menu,
Anchor,
Search,
} from 'grommet/components';
vs.
import Header from 'grommet/components/Header';
import Title from 'grommet/components/Title';
import Menu from 'grommet/components/Menu';
import Anchor from 'grommet/components/Anchor';
import Search from 'grommet/components/Search';
Played around a bit with grommet. I am not sure if grommet is stable enough to use it in our project. Maybe we can use grommet as inspiration and write our own framework.