search

scalable-react / scalable-react-typescript-boilerplate

:star: Scalable micro-framework featuring React and TypeScript
https://scalable-react-ts-boilerplate.herokuapp.com/
MIT License
173 stars 26 forks source link

Adjusted prop types on Error element. Added tests. #46

Closed sfleck closed 7 years ago

sfleck commented 7 years ago

Let me know how the onCloseCallback snippet looks. Otherwise, It is just some standard tests.

sfleck commented 7 years ago

I see you added the onCloseCallback snippet we discussed. I just added some comments for future reference if we ever decide to use something other than the Box element.

RyanCCollins commented 7 years ago

Thanks for that! Your tests serve as a great reference for all of us.

I usually avoid comments (prefer code to be as self-documented as possible), but I think in this case it makes total sense. Appreciate it!

RyanCCollins commented 7 years ago

By the way, i think Travis is down right now. I don't think it actually errored, but I will look into it.