scalableminds / webknossos-connect

Connect webKnossos with existing datasets (BossDB, Neuroglancer Precomputed)
GNU Affero General Public License v3.0
0 stars 0 forks source link

switch to pipfile, add pylint & black #8

Closed jstriebel closed 5 years ago

jstriebel commented 5 years ago

This PR adds some project setup:

hotzenklotz commented 5 years ago

Regarding Python 3.7: IIRC, our other libs (wkw, wkcuber, seg-tools) all run on Py 3.6 for compatibility. Some dependencies are not available for Py 3.7 yet. Perhaps @georgwiese or @philippotto can comment on that.

georgwiese commented 5 years ago

segmentation-tools are still using Python 3.5, because that's what's shipped with the official TF image.

jstriebel commented 5 years ago

I just checked the versions:

I'm fine with using Python 3.6 as well, 3.5 is missing important features for typing. As py-datastore will not be used by one of those libs, having a higher version should not be an issue, so I would go for the most recent, but 3.6 is also fine for me. Using the libs should not be a problem anyways, as the versions are downward-compatible.

CCing @normanrz , as he seemed to setup most of the other python projects.

normanrz commented 5 years ago

If all the deps are compatible with 3.7, I don‘t see why we shouldn’t use ot for this project. Eventually, TF will also support it and we can also migrate segm-tools.

normanrz commented 5 years ago

I think it is convention to not use dashes in module names on Python, or is it?

jstriebel commented 5 years ago

I think it is convention to not use dashes in module names on Python, or is it?

It is, I'm changing it in PR #9