search

scalableminds / webknossos-wrap

Efficient 3D volume storage format for webKnossos and analyses
MIT License
8 stars 3 forks source link

MATLAB: Make `wkwBoundingBox` robust and platform agnostic #63

Closed amotta closed 3 years ago

amotta commented 3 years ago

This commit makes MATLAB's wkwBoundingBox platform agnostic and fixes #62.

Pull request #37 by @mgschm addresses the same issue. It does so by changing the regular expression in a platform-dependent manner. Here, a more robust alternative is proposed: We now use MATLAB's built-in fileparts function instead of regular expressions. This function also handles any cross-platform differences.

@sahilloomba @mgschm Could you please test this on Windows?

sahilloomba commented 3 years ago

This fixes the bug on Windows, thanks.

amotta commented 3 years ago

Great! Thanks for testing.

In this case, could you please approach the merge request? This way we can merge the changes into master and eventually update the submodules of our internal repositories.

amotta commented 3 years ago

Thanks a lot, Norman!