Arbitrary not honored

[boergens]

For task types

Backend:

• [x] Change mode mode names in backend
• [x] Create evolution for existing data

Log Time

[boergens]

I can't take out more, because otherwise it isn't clear anymore what we have the task types for att all

[boergens]

So we discussed it and the flag now mean different things. If the first is set, spherical mode should be disabled (greyed out), if the second, oblique mode.

[daniel-wer]

I changed the frontend and templates to reflect the proposed change for a task type. Possible settings are "Allow spherical" and "Allow oblique". The tracing view will honor these allowed modes called "spherical" and "oblique". The 3-plane mode is from now on always allowed.

However @jfrohnhofen or @tmbo , the backend needs to be adjusted to reflect those changes as for example an Annotation still thinks the possible values for allowed modes are called "oxalis" and "arbitrary", they should be "spherical" and "oblique". We would also need an evolution, that removes "oxalis" from the allowed modes in all task types and annotations (not high priority) and replaces "arbitrary" by "spherical" and "oblique" (high priority). The changes should be implemented on branch OX-766 and will only be merged to the review branch.

[boergens]

@daniel-wer Found something :-) It is not possible to disable both spherical and oblique. This was a feature because the old way it would have been bad to disable everything. Now it's a bug

[boergens]

Also,

• it is still not honored by the explorative tracing EDIT: meant the tracing window
• can't the hidden input field in task_type_form_view.coffee now be removed
• the form allows input 0 hours. It shouldn't

[tmbo]

@daniel-wer what is the reason for the changes being review only? Please assign the issue to me when you are done.

[daniel-wer]

Yes it is still not honored as there is backend work missing as I wrote. Will look into allowing to disable both settings if that's restricted in the frontend and then hand over to @tmbo. @kevinbbb87: Please create a separate issue for the hours thing.

There are changes from other issues related to the spherical/oblique renaming that are so far only done on the review branch, that's why this issue is review only so far as well.

[tmbo]

Can you please point to those changes? This needs to go on to master as well.

[daniel-wer]

Disabling both settings has to be allowed in the backend. I haven't seen an issue for the other changes, think they were done without an issue or PR, they seem to be mostly in this commit d44c24d90e57955f793f2e4282202652309c867b though.

[tmbo]

Ok so this is related to #777 and should be branched of master after that one is ported to master.

[georgwiese]

Ported the existing stuff to OX-766-master

[georgwiese]

For next steps, see #809

[georgwiese]

Merged into review, so I'll remove the release-important label.

[jfrohnhofen]

@georgwiese don't forget to drop / adjust the database to avoid confusion

[georgwiese]

That should be done anyway for the reviewers so they start with a clean state...

[boergens]

I think it will happen a couple of times as we extend the default deploy with task etc.