coderabbitai[bot]
commented
1 week ago Walkthrough
The changes in this pull request involve updates to two GitHub workflow files and a TypeScript file related to Puppeteer testing. In the workflow files, a conditional statement if: always() was added to the "Upload screenshots as artifact" step, ensuring that screenshots are uploaded regardless of the success or failure of preceding steps. In the TypeScript file, a new function for retrieving the BrowserStack session ID was introduced, and modifications were made to enhance session management and logging during Puppeteer tests.
Changes
| File Path | Change Summary |
|---|---|
.github/workflows/nightly.yml |
Updated action version to actions/upload-artifact@v4 and added if: always() to "Upload screenshots as artifact" step to ensure execution regardless of previous step outcomes. |
.github/workflows/wkorg-nightly.yaml |
Updated action version to actions/upload-artifact@v4 and added if: always() to "Upload screenshots as artifact" step within nightly-screenshot-tests job to ensure screenshots are uploaded even if tests fail. |
frontend/javascripts/test/puppeteer/dataset_rendering_helpers.ts |
Introduced getBrowserstackSessionId function for retrieving session ID from BrowserStack. Updated setupBeforeEachAndAfterEach to include name in caps and modified browser instance handling. Minor logging enhancements added. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant GitHub Actions
participant Puppeteer
participant BrowserStack
User->>GitHub Actions: Trigger nightly workflow
GitHub Actions->>Puppeteer: Start tests
alt Tests succeed
Puppeteer->>GitHub Actions: Upload screenshots
else Tests fail
Puppeteer->>GitHub Actions: Upload screenshots
end
GitHub Actions->>User: Notify completion🐰 "In the workflows, a change so bright,
Screenshots now upload, day or night.
With BrowserStack, we fetch the ID,
Our tests run smoothly, oh yes indeed!
So hop along, let's celebrate,
With joyful bounces, it's truly great!" 🥕
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
hotzenklotz
Changes:
Steps to test:
(Please delete unneeded items, merge only when none are left open)
Summary by CodeRabbit
New Features
Bug Fixes
Documentation