Open frcroth opened 2 days ago
The pull request introduces significant enhancements to the WEBKNOSSOS application, primarily focusing on error handling and validation improvements for job processing. Key changes include the implementation of asynchronous reading of image files, enhanced error messages related to job initiation on datasets from other organizations, and the addition of an organizationId
parameter across various job-related functions. These modifications aim to provide clearer feedback and enforce stricter access controls based on organizational context.
Files | Change Summary |
---|---|
CHANGELOG.unreleased.md | Updated to document new features, including asynchronous image file reading and improved error messages. |
app/controllers/AiModelController.scala | Enhanced error handling and validation logic; added organizationId field and localized error messages. |
app/controllers/JobController.scala | Improved error handling and validation; updated method signatures to include organizationId . |
conf/messages | Modified and added error messages for job permissions related to organizational access. |
frontend/javascripts/admin/api/jobs.ts | Updated RunInferenceParameters type to include organizationId ; adjusted runInferenceJob function. |
frontend/javascripts/oxalis/view/action-bar/starting_job_modals.tsx | Enhanced job submission process; integrated organizationId into job parameters. |
Objective | Addressed | Explanation |
---|---|---|
Misleading error message when starting jobs for datasets of other organizations (#8165) | ✅ | |
Improved error message for unauthorized organization access (#8165) | ✅ | |
Unified error messages across different job functions (#8165) | ✅ |
AiModelController.scala
file regarding the organizationId
field are related to the main PR's improvements in error messages for job initiation on datasets, as both involve organization validation.conf/messages
regarding job permissions align with the main PR's focus on improving error messages related to job initiation and organization access.AnnotationIOController.scala
to enhance downloading tasks for teams not joined relate to the main PR's improvements in error handling and user feedback during job initiation.ScrollableVirtualizedTree
component enhances the user experience during drag-and-drop operations, which complements the main PR's focus on improving error messages and user feedback.forwardRef
in the ScrollableVirtualizedTree
component ensures proper reference handling, which is crucial for maintaining functionality in the context of the main PR's enhancements to error handling and user interactions.bug
, backend
In the meadow where data flows,
New features bloom, as progress shows.
With clearer messages, we guide the way,
Enhancements sprout, brightening the day.
So hop along, let’s celebrate,
For WEBKNOSSOS grows, it’s truly great! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
URL of deployed dev instance (used for testing):
Steps to test:
As I understand the runInference Job, it is not necessary there because the organization is taken from the user's identity anyway.Issues:
(Please delete unneeded items, merge only when none are left open)
Summary by CodeRabbit
Release Notes
New Features
organizationId
to job parameters, enhancing context in job processing.Bug Fixes
Improvements