Closed MichaelBuessemeyer closed 1 week ago
The changes in this pull request focus on the ScrollableVirtualizedTree
component, enhancing its structure by implementing forwardRef
to better manage refs. The internal function was renamed to ScrollableVirtualizedTreeInner
, and its parameters were adjusted accordingly. Additionally, the SegmentsView
class was modified to simplify the usage of ScrollableVirtualizedTree
by removing a generic type parameter. Improvements were made to state management, user interactions, and error handling within the SegmentsView
, ensuring a more intuitive experience without altering core functionalities.
File Path | Change Summary |
---|---|
frontend/javascripts/oxalis/view/right-border-tabs/scrollable_virtualized_tree.tsx | - Updated ScrollableVirtualizedTree to use forwardRef and renamed inner function to ScrollableVirtualizedTreeInner . - Adjusted function signature to separate props and ref . - Updated export statement to reflect new structure. |
frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segments_view.tsx | - Removed generic type parameter <SegmentHierarchyNode> from ScrollableVirtualizedTree instantiation. - Enhanced methods for segment selection, visibility management, and error handling. - Updated lifecycle methods for better mesh file fetching and job data polling. |
CHANGELOG.unreleased.md | - Documented new features including metadata for annotations, time tracking summary, improved search, and support for OME-Zarr NGFF datasets. - Listed changes to existing functionalities and fixed various bugs affecting user experience. |
ScrollableVirtualizedTree
component, which is directly related to the changes made in the main PR that also focuses on the ScrollableVirtualizedTree
component's structure and ref handling.CHANGELOG
that include updates related to the ScrollableVirtualizedTree
, which is relevant to the main PR's focus on this component.SegmentListItem
component, which interacts with the ScrollableVirtualizedTree
in the segments tab, making it relevant to the main PR.ScrollableVirtualizedTree
component in the main PR.ScrollableVirtualizedTree
, making it relevant to the main PR.π In the code we hop and play,
Refactoring makes a brighter day.
With trees that scroll and segments neat,
Our UI dances, oh so sweet!
Forward refs, we now embrace,
In our code, we find our place! π
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
The newly deployed scrollable fix added a wrapper for the antd tree implementation. The wrapper is functional component which needs to be wrapped in a
forwardRef
as it received a ref which should be forwarded to the antd tree component. TheforwardRef
was missing and is now added in this pr.URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Refactor