Do not restrict bbox size for inferral jobs for super users

MichaelBuessemeyer commented 1 week ago

URL of deployed dev instance (used for testing):

https://___.webknossos.xyz

Steps to test:

I suggest to test locally
checkout master
run yarn enable-jobs, in application.conf set exportTiffMaxVolumeMVx = 100 and exportTiffMaxEdgeLengthVx = 100
open a relatively large dataset and try to run an inferral job on the whole dataset. The form input should be rejected by the frontend due to the whole ds being too large for whats allowed
checkout this branch
Do the same again, this time submitting the job should succeed (with sample@scm.io)

Issues:

fixes https://scm.slack.com/archives/C5AKLAV0B/p1731586311738809

(Please delete unneeded items, merge only when none are left open)

[x] Updated changelog

Summary by CodeRabbit

New Features
- System now ignores format prefixes like precomputed:// when pasting remote URIs from Neuroglancer.
- Asynchronous image file reading for improved performance.
- Removed bounding box size restrictions for super users, enhancing job configuration flexibility.
Bug Fixes
- Resolved performance bottleneck when deleting multiple trees.
- Fixed import issues with NML files containing only groups.
- Corrected deletion error when attempting to delete a non-existing node via the API.
Enhancements
- Improved user permission handling for bounding box selection in job initiation processes.
- Enhanced error messages for starting jobs on datasets from other organizations.

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes in this pull request involve updates to the WEBKNOSSOS project, focusing on asynchronous image file handling and modifications to bounding box configurations for super users. The changelog highlights performance improvements and bug fixes, including resolving issues with tree deletions and NML file imports. Additionally, user permissions related to bounding box selection have been refined in the frontend code, allowing super users to bypass certain validation checks.

Changes

File Path	Change Summary
CHANGELOG.unreleased.md	Updated to document asynchronous image file handling, removal of bounding box size restrictions for super users, and various bug fixes related to performance and tree deletions.
frontend/javascripts/oxalis/view/action-bar/starting_job_modals.tsx	Enhanced bounding box selection functionality by adding `isSuperUser` property, updating validation logic, and modifying UI rendering based on user permissions. Adjusted type signatures for relevant props.

Possibly related PRs

#8152: Addresses the export functionality of bounding boxes, related to the removal of bounding box size restrictions for super users.
#8164: Allows deletion of bounding boxes without a visible segmentation layer, aligning with updates on bounding box handling.
#8176: Fixes a performance bottleneck when deleting multiple trees, relevant to performance improvements in the main PR.
#8181: Enhances error messaging for job initiation, relevant to the main PR's updates on user-facing changes and error handling improvements.
#8195: Introduces a feature that simplifies user interactions with remote URIs, complementing the main PR's focus on improving user experience.

Suggested labels

bug

Suggested reviewers

normanrz

🐇 In a world of boxes, big and small,
Super users can now stand tall.
With bugs all fixed and files in line,
Asynchronous reads make it all just fine.
So hop along, let’s start the show,
In WEBKNOSSOS, we’re ready to go! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

MichaelBuessemeyer commented 1 week ago

@normanrz I just assigned you in case you have time. If you do not, feel free to re-assign the review :)

MichaelBuessemeyer commented 4 days ago

@dieknolle3333 Do you maybe have some time to look at this PR? It is pretty small :snail:

scalableminds / webknossos