Closed fm3 closed 6 days ago
The pull request involves the removal of Google Analytics from the WEBKNOSSOS project, including the deletion of related tracking functions and configuration options. Asynchronous file reading has been implemented for improved efficiency, and several performance fixes have been made, including resolving issues with tree deletions and NML file imports. The migration guide has been updated to reflect these changes, particularly regarding the removal of the Google Analytics tracking ID.
File Path | Change Summary |
---|---|
CHANGELOG.unreleased.md | Updated to reflect changes including removal of Google Analytics and performance fixes. |
MIGRATIONS.unreleased.md | Added note about removal of googleAnalytics.trackingId . |
app/utils/WkConf.scala | Removed GoogleAnalytics object and updated children list. |
app/views/main.scala.html | Removed Google Analytics tracking functionality from HTML. |
conf/application.conf | Removed Google Analytics section and updated various settings. |
frontend/javascripts/admin/dataset/dataset_upload_view.tsx | Removed trackAction from finishDatasetUpload , enhanced error handling, and updated validation rules. |
frontend/javascripts/dashboard/advanced_dataset/dataset_table.tsx | Removed trackAction from editTagFromDataset , refined context menu logic. |
frontend/javascripts/dashboard/dataset/dataset_settings_view.tsx | Removed trackAction from submit , enhanced user feedback and validation logic. |
frontend/javascripts/dashboard/explorative_annotations_view.tsx | Removed trackAction from setLockedState and editTagFromAnnotation , updated UI rendering logic. |
frontend/javascripts/main.tsx | Removed googleAnalyticsLogClicks function from click event listener. |
frontend/javascripts/navbar.tsx | Renamed getAndTrackVersion to getVersion , removed tracking functionality. |
frontend/javascripts/oxalis/model/helpers/analytics.ts | Deleted file containing Google Analytics tracking functions. |
frontend/javascripts/oxalis/model/sagas/settings_saga.ts | Removed trackUserSettingsAsync , refined error handling in pushDatasetSettingsAsync . |
frontend/javascripts/oxalis/view/action_bar_view.tsx | Removed trackAction from createAnnotation , updated additional coordinates handling. |
frontend/javascripts/oxalis/view/nml_upload_zone_container.tsx | Removed trackAction from onDrop , no other changes. |
frontend/javascripts/router.tsx | Removed Google Analytics tracking for page views and trackAction from routing logic. |
Objective | Addressed | Explanation |
---|---|---|
Remove Google Analytics (7388) | ✅ |
ScrollableVirtualizedTree
component, which enhance the functionality of the tree view, are relevant as they contribute to the overall user experience improvements mentioned in the main PR.bug
"In the garden where data used to play,
Google Analytics has hopped away.
With trees now deleted and files read fast,
Our code is cleaner, improvements amassed.
No more tracking, just joy in the air,
A brighter path for all who dare!" 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Steps to test:
Issues:
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Chores