search

scalacenter / bloop-config

Bloop configuration library
https://scalacenter.github.io/bloop/docs/configuration-format
Apache License 2.0
1 stars 4 forks source link

refactor: split out a test util module #5

Closed ckipp01 closed 1 year ago

ckipp01 commented 1 year ago

In the Bloop code base the integration tests also actually use this trait. It's only a single file so in reality we could duplicate it in Bloop, but I figured we could also simply publish it as a mini-module that Bloop could just use in its integration tests. It's not really cleaned up or anything special, so I'm unsure if anything other than Bloop will actually use this.

Bloop would then simply add:

Dependencies.bloopConfigTestUtil % Test

To the plugin modules.

Refs: https://github.com/scalacenter/bloop/pull/1868

ckipp01 commented 1 year ago

I think it should be fine to keep it in Bloop only. It's a lot of internal logic, so it would be akward to use anywhere else.

Can you clarify what you mean? It'll only be Bloop that uses this right? But I'd still need to publish this though as both Bloop and this repo use it for testing.

tgodzik commented 1 year ago

I think it should be fine to keep it in Bloop only. It's a lot of internal logic, so it would be akward to use anywhere else.

Can you clarify what you mean? It'll only be Bloop that uses this right? But I'd still need to publish this though as both Bloop and this repo use it for testing.

Ach, ok! I didn't know it's also used here. I thought it's only used for testing gradle and maven integration.

tgodzik commented 1 year ago

Wait, but is it really? I only see the definition https://github.com/scalacenter/bloop-config/search?q=BaseConfigSuite

Or are talking about another class?

ckipp01 commented 1 year ago

Wait, but is it really? I only see the definition https://github.com/scalacenter/bloop-config/search?q=BaseConfigSuite

Whoa, you're right, how the heck did I miss this. I'll move this out of here, sorry for the confusion!