Closed MasseGuillaume closed 5 years ago
Merging #51 into master will increase coverage by
3.51%
. The diff coverage is89.04%
.
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 83.42% 86.94% +3.51%
==========================================
Files 32 29 -3
Lines 1231 1501 +270
Branches 87 121 +34
==========================================
+ Hits 1027 1305 +278
+ Misses 204 196 -8
Impacted Files | Coverage Δ | |
---|---|---|
.../scala/meta/internal/prettyprinters/TokenOps.scala | 80% <ø> (+40%) |
:arrow_up: |
...scala/meta/internal/prettyprinters/DiffSuite.scala | 30% <ø> (ø) |
:arrow_up: |
.../scala/meta/internal/prettyprinters/Comments.scala | 90.9% <0%> (ø) |
:arrow_up: |
...a/scala/meta/internal/prettyprinters/package.scala | 100% <100%> (ø) |
|
...ala/meta/internal/prettyprinters/TreePrinter.scala | 99.4% <100%> (-0.27%) |
:arrow_down: |
...scala/meta/internal/prettyprinters/TokensOps.scala | 74.54% <16.66%> (-12.42%) |
:arrow_down: |
.../meta/internal/prettyprinters/MatchingParens.scala | 73.07% <44.44%> (+6.41%) |
:arrow_up: |
...internal/prettyprinters/BaseScalaPrinterTest.scala | 68.31% <60.86%> (-0.92%) |
:arrow_down: |
...scala/meta/internal/prettyprinters/TokenList.scala | 76.19% <76.19%> (ø) |
|
...rnal/prettyprinters/tokens/SyntaxTokensUtils.scala | 95.45% <85.71%> (-4.55%) |
:arrow_down: |
... and 12 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 39675f2...94d0fef. Read the comment docs.
Here is my workflow:
1) Run the PlaygroundSuite with
cover = true
to get the next failing slow testhttps://github.com/scalacenter/scala-syntax/blob/c7cff63a19dce7214dcc2876f2627fcdb056193c/tests/unit/src/test/scala/scala/meta/internal/prettyprinters/PlaygroundSuite.scala
unit/testOnly scala.meta.internal.prettyprinters.PlaygroundSuite
2) open
output/input.scala
andoutput/obtained.scala
and see where the comment is missing3) copy
output/input.scala
intotests/unit/src/test/resources/playground.scala
and minimize the example4) set
cover = false
and rununit/testOnly scala.meta.internal.prettyprinters.PlaygroundSuite
5) add the missing t.
(
or t.symbol
, etc in TreePrinter.scala and the extension method in SyntaxToken.scala6) copy the minimize example from playground.scala to comments2.scala