scalacenter / scalafix.g8

Giter8 template to implement custom rewrites
10 stars 9 forks source link

Update sbt to 1.9.0 #100

Closed scala-center-steward[bot] closed 1 year ago

scala-center-steward[bot] commented 1 year ago

Updates org.scala-sbt:sbt from 1.8.3 to 1.9.0. GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates Add this to your `.scala-steward.conf` file to ignore future updates of this dependency: ``` updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ] ``` Or, add this to slow down future updates of this dependency: ``` dependencyOverrides = [{ pullRequests = { frequency = "30 days" }, dependency = { groupId = "org.scala-sbt", artifactId = "sbt" } }] ```

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

bjaglin commented 1 year ago

[error] sbt.librarymanagement.ResolveException: Error downloading org.scalameta:semanticdb-scalac_2.12.18:4.6.0

Scalameta 4.6.0 is brought by Scalafix 0.10.4. It looks like https://search.maven.org/solrsearch/select?q=g:%22ch.epfl.scala%22+AND+a:%22sbt-scalafix%22&rows=10&wt=xml is stale as it does not return 0.11.0.

julienrf commented 1 year ago

I’ve noticed some issues with the search tool, but the artifacts are there: https://repo1.maven.org/maven2/ch/epfl/scala/sbt-scalafix_2.12_1.0/0.11.0/

julienrf commented 1 year ago

Do we need to update both sbt and sbt-scalafix?

bjaglin commented 1 year ago

I’ve noticed some issues with the search tool, but the artifacts are there: https://repo1.maven.org/maven2/ch/epfl/scala/sbt-scalafix_2.12_1.0/0.11.0/

Right, the problem is that the link I posted above is used internally in giter8, so now that the default in sbt 1.9.0 is scala 2.12.18, the latest version of scalafix supporting it is needed.

bjaglin commented 1 year ago

Do we need to update both sbt and sbt-scalafix?

Both are driven by sbt-scalafix, so it does look like the problem is related to the search response. I don't see how, but I'll see later if this might be caused by the double POM publishing introduced in 1.9.0 (used to publish sbt-scalafix 0.11.0).

bjaglin commented 1 year ago

I don't see how, but I'll see later if this might be caused by the double POM publishing introduced in 1.9.0 (used to publish sbt-scalafix 0.11.0).

It really doesn't look like it, so I filed https://github.com/foundweekends/giter8/issues/802

bjaglin commented 1 year ago

Trying things in https://github.com/scalacenter/scalafix.g8/pull/102 to unblock that (and fix the underlying issue of stale version)

scala-center-steward[bot] commented 1 year ago

Superseded by #103.