scalacenter / scalafix

Refactoring and linting tool for Scala
https://scalacenter.github.io/scalafix/
BSD 3-Clause "New" or "Revised" License
826 stars 186 forks source link

core: reduce amount of scalac dependencies #2048

Closed bjaglin closed 1 month ago

bjaglin commented 1 month ago

Follows https://github.com/scalacenter/scalafix/pull/2047 / https://github.com/scalameta/scalameta/pull/3747

See initial discussion in https://github.com/scalacenter/scalafix/pull/2024#discussion_r1703407620

I initially tried to inline everything that was needed from semanticdb-scalac-core, but I ended up pulling pretty much everything.... It's not a big difference compared to before anyway, as the Scala 2 compiler is brought by scalameta (the main artifact). As discussed in one of the comment, that logic will have to be revisited anyway to better support Scala 3 (https://github.com/scalacenter/scalafix/issues/2049), so I am not sure it's worth investing time on that now.