search

scalacenter / scalajs-bundler

https://scalacenter.github.io/scalajs-bundler
Other
237 stars 101 forks source link

Define a custom setting to indicate DOM JsEnv in test #266

Closed ngbinh closed 6 years ago

ngbinh commented 6 years ago

should allow us to get rid of the already deprecated requiresDOM setting in scala.js.

should address #181

julienrf commented 6 years ago

The changes look good, I haven't had a look at the CI failure (on my mobile phone right now). Can you also update the user documentation (in reference.md at least) and the changeling?

ngbinh commented 6 years ago

Thanks. I will update changelog.

cquiroz commented 6 years ago

👏👏 this is great

ngbinh commented 6 years ago

Update reference and changelog.

ngbinh commented 6 years ago

updated

ngbinh commented 6 years ago

Will work on this one today. Hope to be able to merge

julienrf commented 6 years ago

Thanks @ngbinh!