search

scalacenter / scalajs-bundler

https://scalacenter.github.io/scalajs-bundler
Other
237 stars 101 forks source link

Discriminate WARN/notice logs from npm logs #268

Closed exoego closed 6 years ago

exoego commented 6 years ago

Addresses #209

exoego commented 6 years ago

It seems that AppVeyor on sbt 1.0.2 was aborted https://ci.appveyor.com/project/julienrf/scalajs-bundler/build/629/job/3bsgv7c7uemllu7n suddenly. A sign of fragile test? 🤔

So closed PR -> reopend PR to restart CI.

exoego commented 6 years ago

I close this PR since

  1. npm prints lots of messages that are hard to discriminate as warn.

One example is security audit warning which do not start with warn or something.

[error] audited 5940 packages in 6.075s
[error] found 24 low severity vulnerabilities
[error]   run `npm audit fix` to fix them, or `npm audit` for details
  1. This PR resolve obvious cases, but in other cases, users may get confused when seeing [error]. We may not get confused if every npm logs are printed as [error] consistently.
julienrf commented 6 years ago

Thanks @exoego for having worked on that!