search

scalacenter / scalajs-bundler

https://scalacenter.github.io/scalajs-bundler
Other
234 stars 101 forks source link

small documentation typo: emitSourceMaps should be webpackEmitSourceMaps #342

Closed evbo closed 3 years ago

evbo commented 4 years ago

With 0.17.0 this cookbook recipe is no longer accurate: https://scalacenter.github.io/scalajs-bundler/cookbook.html#performance

It has been refactored and should read:

webpackEmitSourceMaps := false

didnt see any documentation PRs in flight so I thought it'd be useful to point out ;)

evbo commented 4 years ago

also, perhaps a bigger issue is that I don't seem to be able to disable emitting source maps. Ultimately I'm just disabling them inside chrome devtools. I've cleaned my target directory ensuring nothing was left over, unless chrome somehow caches them...

fdietze commented 3 years ago

This works for me:

webpackEmitSourceMaps in fullOptJS := false,
evbo commented 3 years ago

looks like this was fixed - thanks