search

scalacenter / scalajs-bundler

https://scalacenter.github.io/scalajs-bundler
Other
234 stars 101 forks source link

Upgrade to sbt-web-scalajs v1.1.0 #351

Closed vmunier closed 4 years ago

sjrd commented 4 years ago

This needs to be rebased on top of the latest master, now that #352 has been merged.

vmunier commented 4 years ago

Got Cannot assign to read only property 'global' of object '#<Object>' with Scala.js 0.6.33 when > client/test is run as part of runScripted.

Adding > set scalaJSStage in Global := FastOptStage before > client/test makes the test pass. Not sure why this error does not occur with Scala.js 1.x

vmunier commented 4 years ago

Thanks for the review! I applied the changes