search

scalacenter / scalajs-bundler

https://scalacenter.github.io/scalajs-bundler
Other
237 stars 101 forks source link

update version on install instructions to 0.20.0 #413

Closed fiatjaf closed 2 years ago

fiatjaf commented 2 years ago

fixes https://github.com/scalacenter/scalajs-bundler/issues/402

sjrd commented 2 years ago

I could merge this, but it would be overwritten by a bot on the next merge on main. The actual source for this is at https://github.com/scalacenter/scalajs-bundler/blob/b37024143b5a194de11a4395b367711eec2a3248/manual/src/ornate/index.md?plain=1#L11-L14 We should probably replace the dynamic {{version}}s by hard-corded ones.

fiatjaf commented 2 years ago

Why is the {{version}} printing the wrong value though? It would work if {{version}} corresponded to the latest release.

sjrd commented 2 years ago

I don't know. It's possible that the value of {{version}} comes from https://github.com/scalacenter/scalajs-bundler/blob/d083e6df3fe2ac795ae16ba69696039bf85f85a3/manual/src/ornate.conf#L17 However, I don't know where the ${version} comes from. :man_shrugging:

fiatjaf commented 2 years ago

ahahah, well, apparently it is a built-in thing from ornate, and there seems to be also a ${tag} value.

I should try to rebuild the pages using that and send a proper PR, but I'm just trying to learn the basic of basics of Scala here and all these sbt things are imploding my head already so I'll refrain from doing it now :P